Skip to content

Paging blobs - #1208

Merged
MikeNeilson merged 14 commits into
USACE:developfrom
rma-rripken:feature/1195_paging_blobs
Sep 15, 2025
Merged

Paging blobs#1208
MikeNeilson merged 14 commits into
USACE:developfrom
rma-rripken:feature/1195_paging_blobs

Conversation

@rma-rripken

Copy link
Copy Markdown
Collaborator

Does writing DSL queries with manually created table and column references even work? I don't think we've tried doing this anywhere else.

@rma-rripken

Copy link
Copy Markdown
Collaborator Author

This needs IT that test Blob paging.

@MikeNeilson

Copy link
Copy Markdown
Contributor

Does writing DSL queries with manually created table and column references even work? I don't think we've tried doing this anywhere else.

It does, but it can get a little wonky because of the way the table is assigned to the field... or the field to the table.

Here's an example:

public Users getAll(String cursor, int pageSize, String office, boolean includeRoles) {

But you seems to already be on the right track. in the above I'm doing it so JOOQ doesn't create a new unique name on every query, but same context of just knowing what a table is and manually wrapping it. Likely would've done that for more of Auth/User stuff if I was aware at the time I did it. (though the Auth queries were pretty simple.)

@rma-rripken

Copy link
Copy Markdown
Collaborator Author

I've added what I think is the missing IT test. Something in my docker config has broken so I can't run and verify these changes locally and its going to be several weeks before I'm able to work on this again. If someone else wants to take over the PR, have at it. I think its ready.

@rma-rripken
rma-rripken marked this pull request as ready for review August 8, 2025 17:44
MikeNeilson
MikeNeilson previously approved these changes Sep 5, 2025
@rma-rripken

Copy link
Copy Markdown
Collaborator Author

@MikeNeilson merging develop dismissed previous reviews.

@MikeNeilson
MikeNeilson merged commit 051e7b1 into USACE:develop Sep 15, 2025
8 checks passed
MikeNeilson pushed a commit that referenced this pull request Oct 23, 2025
MikeNeilson pushed a commit that referenced this pull request Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants