Actually output the trace context in the docker image. - #1884
Conversation
48a0a20 to
33e266e
Compare
oskarhurst
left a comment
oskarhurst
left a comment
There was a problem hiding this comment.
I think you changes to Juli might break tomcats logging
| @@ -19,10 +23,10 @@ | |||
There was a problem hiding this comment.
should this also be OTEL-STDERR ?
| </appender> | ||
| </appender> | ||
|
|
||
| <appender name="OTEL-STDERR" class="io.opentelemetry.instrumentation.logback.mdc.v1_0.OpenTelemetryAppender"> |
There was a problem hiding this comment.
Correct me if I am wrong but isn't OpenTelemetryAppender unshaded so it could never resolve and use the shaded classes provided by juli. Also isn't locgback-juli only run inside of tomcat would would never have any cda trace-ids to begin with so we only need the change in the normal logback file to add the traces ids?
There was a problem hiding this comment.
For anyone reading this PR:
The tomcat-juli jar is removed from the image and replaced with tomcat9-slf4j-logback, see
Line 43 in a2be20c
Thus, no issues with any shading as that jar deals with it for us.
758b9cb to
e640402
Compare
Sorry, missed this original comment. Doesn't so much break it as totally replaces it. |
2 participants
Summary
While working on HydrologicEngineeringCenter/cwms-python#305, discovered that while we process the traceparent header, we never actually output the trace_id and span_id for viewing and analysis in the logs.
Related Issue
Closes #
Validation
Describe how this was tested.
Checklist