Skip to content

Modal update #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bmulcahy wants to merge 3 commits into from
Closed

Modal update #233

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
89be7ef
Passing in additional headless ui props and updated documentation
bmulcahy Aug 27, 2025
fc433ba
Fixed all issues
bmulcahy Aug 27, 2025
89140b4
Merge branch 'main' into modal-update
bmulcahy Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/components/display/modal.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ function Modal({
}

// Check if Role exists
if (!roleOptions[role]) {
if (!roleOptions.includes(role)) {
console.error(
`Invalid role option for dialog ${role}. Must be one of: 'dialog','alertdialog'`)
console.warn(
Expand All @@ -54,8 +54,8 @@ function Modal({
onClose={onClose}
static= {isStatic}
autoFocus={autoFocus}
dialogTransition={dialogTransition}
unount={unmount}
transition={dialogTransition}
unmount={unmount}
role={role}
className={gwMerge("gw-relative", "gw-z-[200]", className)}
>
Expand Down