Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix windows build #102

Merged
merged 4 commits into from
Mar 28, 2025
Merged

fix windows build #102

merged 4 commits into from
Mar 28, 2025

Conversation

shapiromatron
Copy link
Collaborator

@shapiromatron shapiromatron commented Mar 28, 2025 •
edited
Loading

This occurs on Windows because of a Windows.h header file that redefines min/max; fix by wrapping with parenthesis to prevent macro expansion.

Thank goodness for https://stackoverflow.com/a/27443191/906385.

@shapiromatron shapiromatron changed the title fix windows build; change std::numeric_limits<double>::max() to std::… fix windows build Mar 28, 2025
@shapiromatron shapiromatron requested a review from cwsimmon March 28, 2025 00:44
@shapiromatron shapiromatron marked this pull request as ready for review March 28, 2025 00:56
cwsimmon
cwsimmon approved these changes Mar 28, 2025
View reviewed changes
Copy link
Collaborator

@cwsimmon cwsimmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay stackoverflow! This was a new one for me too. And this does appear to be the correct way to fix. Nice work.

@shapiromatron shapiromatron merged commit 5d24d6c into main Mar 28, 2025
2 checks passed
@shapiromatron shapiromatron deleted the fix-windows-build branch March 28, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwsimmon cwsimmon cwsimmon approved these changes

Assignees

@cwsimmon cwsimmon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shapiromatron @cwsimmon