- 
                Notifications
    
You must be signed in to change notification settings  - Fork 1
 
Fix: package compatibility issues across platform and modules - [PLT-87136] [PLT-90390] [PLT-90489] #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
              
                    Raina451
  
              
              commented
              
                  
                    Oct 6, 2025 
                  
              
              
            
            
              
                    swati354
  
              
              reviewed
              
                  
                    Oct 6, 2025 
                  
              
              
            
            
              
                    swati354
  
              
              reviewed
              
                  
                    Oct 6, 2025 
                  
              
              
            
            
              
                    swati354
  
              
              reviewed
              
                  
                    Oct 6, 2025 
                  
              
              
            
            
              
                    swati354
  
              
              reviewed
              
                  
                    Oct 6, 2025 
                  
              
              
            
            
533a505    to
    e1bc83d      
    Compare
  
    
              
                    swati354
  
              
              reviewed
              
                  
                    Oct 7, 2025 
                  
              
              
            
            
              
                    swati354
  
              
              reviewed
              
                  
                    Oct 7, 2025 
                  
              
              
            
            
| 
           Since we removed the content-type parameter from uploadFile method, we would need to update the comments on that method as well.  | 
    
              
                    swati354
  
              
              reviewed
              
                  
                    Oct 7, 2025 
                  
              
              
            
            
              
                    swati354
  
              
              reviewed
              
                  
                    Oct 7, 2025 
                  
              
              
            
            
              
                    swati354
  
              
              reviewed
              
                  
                    Oct 7, 2025 
                  
              
              
            
            
              
                    swati354
  
              
              reviewed
              
                  
                    Oct 7, 2025 
                  
              
              
            
            
              
                    swati354
  
              
              reviewed
              
                  
                    Oct 7, 2025 
                  
              
              
            
            
              
                    swati354
  
              
              reviewed
              
                  
                    Oct 7, 2025 
                  
              
              
            
            
922e334    to
    521eac2      
    Compare
  
    521eac2    to
    ae884c1      
    Compare
  
    
              
                    swati354
  
              
              approved these changes
              
                  
                    Oct 7, 2025 
                  
              
              
            
            
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
SDK should be fully compatible across:
Issues:
index.d.tsfile was being used for both ESM and CommonJS, causing TypeScript to incorrectly identify the module format.Fix:
rollup.config.js
Added UMD browser bundle with Node.js dependency exclusions
Created separate type declaration builds (.mts, .cts, .d.ts)
Added environment-specific bundling logic
index.d.mts → ESM type declarations
index.d.cts → CommonJS type declarations
index.d.ts → Fallback for legacy tools
Removing unused pkg dependnecies from package.json
removing content-type from upload file method of buckets, as content type is not needed
Tested across: