Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accounts for a root-user with a different name #606

Closed
wants to merge 2 commits into from
Closed

Accounts for a root-user with a different name #606

wants to merge 2 commits into from

Conversation

ngaro
Copy link

@ngaro ngaro commented Feb 27, 2021

Purely in theory, the root user can have another name but he will always have the UID 0.
Although I have never seen this is in real life, this PR solve this 'problem".

It's also a couple of milliseconds faster because id is not forced to look up a name. (Even when asking for a name it will always look up the UID first)

@spirillen
Copy link
Contributor

good idea 👍

@ngaro
Copy link
Author

ngaro commented Feb 27, 2021

An extra commit because of rustysnake's excellent idea in #605 .
I know it's "not done" to do multiple things in 1 pr, but i'm planning some other pr's and i don't want too many merge conflicts in case some pr's are merged and some are closed.

These are extremely readable commits anyway...

@ngaro
Copy link
Author

ngaro commented Feb 27, 2021

This is 'the simple version', i would suggest using #608 where i also do a lot more (but everything is still strongly related)

@funilrys
Copy link
Member

funilrys commented May 2, 2021

Closing as the change is into the more complete #608.

@funilrys funilrys closed this May 2, 2021
@ngaro ngaro deleted the renamedroot branch January 16, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants