Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failure in ftst #460

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Fix failure in ftst #460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
eca8233
Update default cache values.
WardF Feb 6, 2025
e6271ce
Add 4.9.3+ requirement to this version.
WardF Feb 6, 2025
86560a9
Update github action test matrix.
WardF Feb 6, 2025
6987942
Modify cache name.
WardF Feb 6, 2025
619d699
Clean up linux github action.
WardF Feb 26, 2025
ebb5643
Checking to see if there is some error in the 'main' logic
WardF Mar 18, 2025
00de8de
Add a stanza to view the test-suite.logs if there is a failure.
WardF Mar 18, 2025
c2beeab
Add some diagnostic info
WardF Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 15 additions & 8 deletions .github/workflows/run_tests_linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
strategy:
matrix:
hdf5: [ 1.12.2 ]
netcdf: [ v4.7.4, v4.8.1, v4.9.0, main ]
netcdf: [ v4.9.3 ]

steps:

Expand Down Expand Up @@ -75,7 +75,7 @@ jobs:
strategy:
matrix:
hdf5: [ 1.12.2 ]
netcdf: [ v4.7.4, v4.8.1, v4.9.0, main ]
netcdf: [ v4.9.3 ]

steps:

Expand All @@ -101,7 +101,7 @@ jobs:
uses: actions/cache@v4
with:
path: ~/environments/${{ matrix.hdf5 }}-${{ matrix.netcdf }}
key: hdf5-${{ runner.os }}-${{ matrix.hdf5 }}-${{ matrix.netcdf }}-par
key: hdf5-nc-${{ runner.os }}-${{ matrix.hdf5 }}-${{ matrix.netcdf }}-par


- name: Build libhdf5-${{ matrix.hdf5 }}-${{ matrix.netcdf }}-par
Expand Down Expand Up @@ -134,7 +134,7 @@ jobs:
strategy:
matrix:
hdf5: [ 1.12.2 ]
netcdf: [ v4.7.4, v4.8.1, v4.9.0, main ]
netcdf: [ v4.9.3 ]

steps:

Expand Down Expand Up @@ -231,7 +231,7 @@ jobs:
strategy:
matrix:
hdf5: [ 1.12.2 ]
netcdf: [ v4.7.4, v4.8.1, v4.9.0, main ]
netcdf: [ v4.9.3 ]

steps:

Expand Down Expand Up @@ -261,7 +261,7 @@ jobs:
uses: actions/cache@v4
with:
path: ~/environments/${{ matrix.hdf5 }}-${{ matrix.netcdf }}
key: hdf5-${{ runner.os }}-${{ matrix.hdf5 }}-${{ matrix.netcdf }}-par
key: hdf5-nc-${{ runner.os }}-${{ matrix.hdf5 }}-${{ matrix.netcdf }}-par

- name: Check Cache
shell: bash -l {0}
Expand Down Expand Up @@ -314,9 +314,16 @@ jobs:

- name: Run Tests
shell: bash -l {0}
run: CC=${CC} CFLAGS=${CFLAGS} LDFLAGS=${LDFLAGS} LD_LIBRARY_PATH=${LD_LIBRARY_PATH} make check -j
run: CC=${CC} CFLAGS=${CFLAGS} LDFLAGS=${LDFLAGS} LD_LIBRARY_PATH=${LD_LIBRARY_PATH} make check -j 4
if: ${{ success() }}

- name: View Failure Logs
shell: bash -l {0}
run: |
echo -e "\n\n\to NPROC: $(nproc)\n\n"
find . -name "test-suite.log" -exec cat {} \;
if: ${{ failure() }}

#- name: Make Distcheck
# shell: bash -l {0}
# run: CFLAGS=${CFLAGS} LDFLAGS=${LDFLAGS} LD_LIBRARY_PATH=${LD_LIBRARY_PATH} make distcheck -j
Expand All @@ -329,7 +336,7 @@ jobs:
strategy:
matrix:
hdf5: [ 1.12.2 ]
netcdf: [ v4.7.4, v4.8.1, v4.9.0, main ]
netcdf: [ v4.9.3 ]

steps:

Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/run_tests_macos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
strategy:
matrix:
hdf5: [ 1.12.2 ]
netcdf: [ v4.9.0, main ]
netcdf: [ v4.9.3-prep.wif, main ]

steps:

Expand Down Expand Up @@ -79,7 +79,7 @@ jobs:
strategy:
matrix:
hdf5: [ 1.12.2 ]
netcdf: [ v4.9.0, main ]
netcdf: [ v4.9.3-prep.wif, main ]

steps:

Expand Down Expand Up @@ -165,7 +165,7 @@ jobs:
strategy:
matrix:
hdf5: [ 1.12.2 ]
netcdf: [ v4.9.0, main ]
netcdf: [ v4.9.3-prep.wif, main ]

steps:

Expand Down
4 changes: 4 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@ The netCDF Fortran libraries contain both F77 and F90 APIs. For documentation se

* https://docs.unidata.ucar.edu/netcdf-fortran/current/

Requirements
-------------
* NetCDF-C v4.9.3+

Getting NetCDF
--------------

Expand Down
2 changes: 1 addition & 1 deletion nf_test4/ftst_vars.F
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ program ftst_vars
integer DEFAULT_CACHE_SIZE, DEFAULT_CACHE_NELEMS_OLD
integer DEFAULT_CACHE_NELEMS_NEW
integer DEFAULT_CACHE_PREEMPTION
parameter (DEFAULT_CACHE_SIZE = 16777216)
parameter (DEFAULT_CACHE_SIZE = 67108864)
parameter (DEFAULT_CACHE_NELEMS_OLD = 4133)
parameter (DEFAULT_CACHE_NELEMS_NEW = 1000)
parameter (DEFAULT_CACHE_PREEMPTION = 75)
Expand Down
Loading