Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in set_collective added in #1277 #1318

Merged
merged 3 commits into from
Apr 17, 2024
Merged

Fix bug in set_collective added in #1277 #1318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e459ffe
Fix bug in set_collective added in #1277
pgf Apr 16, 2024
98fa362
enable over-subscription
jswhit Apr 17, 2024
9199c86
update
jswhit Apr 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/miniconda.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,8 @@ jobs:
export PATH="${CONDA_PREFIX}/bin:${CONDA_PREFIX}/Library/bin:$PATH"
which mpirun
mpirun --version
#mpirun -np 4 --oversubscribe python mpi_example.py # for openmpi
mpirun -np 4 python mpi_example.py
mpirun -np 4 --oversubscribe python mpi_example.py # for openmpi
#mpirun -np 4 python mpi_example.py
if [ $? -ne 0 ] ; then
echo "hdf5 mpi test failed!"
exit 1
Expand Down
2 changes: 2 additions & 0 deletions Changelog
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
* add support for MS-MPI `MPI_Message` detection (PR #1305)
* fix for issue #1306 - surprising result when indexing vlen str with non-contiguous
indices.
* Fix bug in set_collective introduced in PR #1277 (collective mode was
always set).



Expand Down
2 changes: 1 addition & 1 deletion src/netCDF4/_netCDF4.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6060,7 +6060,7 @@ NC_CHAR).
mode = NC_COLLECTIVE if value else NC_INDEPENDENT
with nogil:
ierr = nc_var_par_access(self._grpid, self._varid,
NC_COLLECTIVE)
mode)
_ensure_nc_success(ierr)


Expand Down