Detect pyenv python installation, and ignore presumed python binaries that don't have correct python version formatting #249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llations that don't have semver formatting. Before, an executable with a name like `python-config` would be detected as python, and it would be assumed that `python-config --version` would return a version in the form of `X.XX.X`. However, this is not always the case with custom commands. Additionally, pyenv installations were not detected, which is common on some systems that only have one python version in their repo. Signed-off-by: carnivorecookies <[email protected]>
greeeen-dev
approved these changes
Oct 30, 2025
Member
greeeen-dev
left a comment
greeeen-dev
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
(Please note that due to current progress on Unifier v4, I may not publish this as a patch release and instead bundle this with v4. You can continue to use your modified version of Unifier until then.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Details
Tests
Output of setup up until user IDs: test.txt
Relevant issues
None