Skip to content

Use ruff for formatting and linting #3370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 15, 2025

Conversation

johannaengland
Copy link
Contributor

And get rid of MegaLinter.

Best reviewed commit by commit.

@johannaengland johannaengland requested a review from a team May 12, 2025 12:34
@johannaengland johannaengland self-assigned this May 12, 2025
@johannaengland johannaengland added the github_actions Pull requests that update GitHub Actions code label May 12, 2025
Copy link

github-actions bot commented May 12, 2025

Test results

   12 files     12 suites   11m 36s ⏱️
2 194 tests 2 194 ✅ 0 💤 0 ❌
6 057 runs  6 057 ✅ 0 💤 0 ❌

Results for commit f64f89a.

♻️ This comment has been updated with latest results.

Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well would you look at that. Ruff even fixed the annoying string-concatenation-after-reformatting issues that Black wouldn't.

Also nice to get rid of all of those old u"" strings from Python 2 :-)

@johannaengland johannaengland force-pushed the workflows/use-ruff-for-everything branch from 856b67e to f64f89a Compare May 15, 2025 10:18
@johannaengland johannaengland merged commit 3e6c457 into master May 15, 2025
13 checks passed
@johannaengland johannaengland deleted the workflows/use-ruff-for-everything branch May 15, 2025 10:34
Copy link

codecov bot commented May 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (6fdf19a) to head (f64f89a).
Report is 8 commits behind head on master.

Additional details and impacted files
@@      Coverage Diff       @@
##   master   #3370   +/-   ##
==============================
==============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants