-
Notifications
You must be signed in to change notification settings - Fork 328
FIX: Use android-execution image for Test runs #2260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
PR Code Suggestions ✨No code suggestions found for the PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #2260 +/- ##
===========================================
- Coverage 76.70% 76.63% -0.08%
===========================================
Files 465 472 +7
Lines 87919 88278 +359
===========================================
+ Hits 67442 67654 +212
- Misses 20477 20624 +147 Flags with carried forward coverage won't be shown. Click here to find out more. see 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Cancelling all jobs running on this branch due to Android jobs being broken and stuck - see https://unity.slack.com/archives/C94RMJJ5T/p1760644095487229 Follow that thread to see when Lukas has a fix for the issue. Please refrain from rerunning the tests until the fix is available and you have it merged in this branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this PR. Not my area of expertise but LGTM. Added @windxu88 to PR as well but might be so urgent we should land anyways I guess to avoid creating problems in Android queue.
Description
Android Jobs use Package-CI images to execute tests, but those images do not contain tools like SDK. This PR switches. the run job image to more appropriate android-execution image.
Testing status & QA
Android Tests
Overall Product Risks
Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.
Comments to reviewers
Please describe any additional information such as what to focus on, or historical info for the reviewers.
Checklist
Before review:
Changed
,Fixed
,Added
sections.Area_CanDoX
,Area_CanDoX_EvenIfYIsTheCase
,Area_WhenIDoX_AndYHappens_ThisIsTheResult
.During merge:
NEW: ___
.FIX: ___
.DOCS: ___
.CHANGE: ___
.RELEASE: 1.1.0-preview.3
.After merge: