FIX: Fixed ISXB-586 for 2022.3.69f1 and up. #2261
Conversation
# Conflicts: # Packages/com.unity.inputsystem/CHANGELOG.md
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr-agent |
PR Code Suggestions ✨No code suggestions found for the PR. |
benoitalain
changed the title
|
@Pauliusd01 I added you for QA. Could you verify
Or test 2022.3.69f1 and for other versions just trust the process that we'll get bug reports if I regressed anything. The risk of that is pretty low. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #2261 +/- ##
===========================================
+ Coverage 76.70% 76.81% +0.10%
===========================================
Files 465 476 +11
Lines 87919 88645 +726
===========================================
+ Hits 67442 68093 +651
- Misses 20477 20552 +75 Flags with carried forward coverage won't be shown. Click here to find out more. see 25 files with indirect coverage changes 🚀 New features to boost your workflow:
|
benoitalain
changed the title
|
Cancelling all jobs running on this branch due to Android jobs being broken and stuck - see https://unity.slack.com/archives/C94RMJJ5T/p1760644095487229 Follow that thread to see when Lukas has a fix for the issue. Please refrain from rerunning the tests until the fix is available and you have it merged in this branch. |
|
Taking a look today |
There was a problem hiding this comment.
Here's what I've checked so far and I'm getting errors on 6.0.14f1:
2022.3.68f1 - no fix for both, no errors or other issues for both in playmode or player
2022.3.69f1 - no fix 1.15.0, fixed on PR 1.15.1, no errors or other issues for both in playmode or player
6000.0.14f1 - no fix 1.15.0, errors on PR 1.15.1
Editor used:
Unity 6 Preview
6000.0.14f1.6822.6000.0/release.4172
Revision: 6000.0/release e12ab2d6a089
Extended it until 2023.0.0 which doesn't seem to exist anymore. This makes sure that from 6.0.0 until 6.0.14 the define doesn't exist.
|
@Pauliusd01 please try again. I believe my last commit fixes it |
4 participants
Description
Original PR: #1975
Jira ticket: https://jira.unity3d.com/browse/ISXB-586
2022.3 PR: https://github.cds.internal.unity3d.com/unity/unity/pull/81547
2022.3 PR has successfully landed before this PR.
Testing status & QA
Adds 2022.3.69f1 to
#defineflagUNITY_INPUT_SYSTEM_SENDPOINTERHOVERTOPARENTwhich was used in original fix.From the original fix:
Implements BaseInputModule sendPointerHoverToParent property for InputSystemUIInputModule. Also properly set PointerEventData reentered and fullyExited properties.
Overall Product Risks
Comments to reviewers
I did not do any kind of testing whatsoever on this backport fix.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.After merge: