Scene hierarchy tree view example #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shantz
reviewed
Jul 4, 2017
| added.RegisterWatch(go, UpdateName); | ||
| UpdateChildren(added, go.transform); | ||
| added.RegisterWatch(go.transform, UpdateChildren); | ||
|
|
There was a problem hiding this comment.
As discussed, we need a lambda here because the delegate does not send the VE with it.
We should change all VisualElement delegates to send the 'this' as context.
shantz
reviewed
Jul 4, 2017
| { | ||
| if (data == null) | ||
| return; | ||
|
|
There was a problem hiding this comment.
could be multiple labels if we change the template.
shantz
reviewed
Jul 4, 2017
| void OnToggle(VisualContainer treeViewItem) | ||
| { | ||
| GameObject go = treeViewItem.data as GameObject; | ||
| Debug.Assert(go != null, "No GO attached to item!"); |
There was a problem hiding this comment.
Let's see how in the next PR we can have a ViewData service to store and retrieve that.
// Off the cuff?
var v = ViewDataStore.GetOrCreateDefault(key);
var v = ViewDataStore.Store(key, 5);
clusty
reviewed
Jul 6, 2017
| } | ||
| Toggle toggle = treeViewItem.Q<Toggle>(); | ||
| toggle.enabled = gos.Count > 0; | ||
| toggle.on = toggle.enabled && m_ExpandedGOs.Contains(transform.gameObject.GetInstanceID()); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple example of custom tree view for the scene hierarchy.
It uses UXML draft implementation in conjunction with UQuery.
Also benefits from some adjustments of DataWatch which is now available in all contexts.