Use productName as Solution if available + Merge patch and generate logic for settings.json #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
1 - This package will set
dotnet.defaultSolution
in Thesettings.json
withsln
that generated from folder nameThis cause unnecessary git change when we have multiple project folder for each platform or the same project in difference machine
2 - Patching did not patch the file exclusions when there is any update of this repo. We need to remove whole
settings.json
to see any update which is not idealSolution
1 - Use
productName
instead. This would be value that more consistence in the project and reflect state of current project more than just the folder name2 - I have merge creation and patching logic and also check for each exclude to specified each exclusion if not exist
Suggestion
I have separate the exclusion setting into it's own array, in the hope that we can have toggle setting to specified what to not exclude in the setting
Also maybe specified
search.exclude
asfalse
for some ascii file, like.unity
and.asset
so I could search for usage