Skip to content

Use productName as Solution if available + Merge patch and generate logic for settings.json #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Thaina
Copy link

@Thaina Thaina commented Jul 27, 2024

Problem

1 - This package will set dotnet.defaultSolution in The settings.json with sln that generated from folder name
This cause unnecessary git change when we have multiple project folder for each platform or the same project in difference machine

2 - Patching did not patch the file exclusions when there is any update of this repo. We need to remove whole settings.json to see any update which is not ideal

Solution

1 - Use productName instead. This would be value that more consistence in the project and reflect state of current project more than just the folder name

2 - I have merge creation and patching logic and also check for each exclude to specified each exclusion if not exist

Suggestion

I have separate the exclusion setting into it's own array, in the hope that we can have toggle setting to specified what to not exclude in the setting

Also maybe specified search.exclude as false for some ascii file, like .unity and .asset so I could search for usage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants