fix: suggested fixes for #3514 #3538
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…com/Unity-Technologies/com.unity.netcode.gameobjects into fix/destroy-in-scene-placed-objects
| @@ -66,6 +66,7 @@ pull_request_trigger: | |||
| - "develop" | |||
| - "develop-2.0.0" | |||
| - "/release\/.*/" | |||
| - "/fix\/.*/" | |||
There was a problem hiding this comment.
Why to add this automatically? My understanding is that we don't need to "waste resources" and enforce the test passing for PRs that are not "landing". So what I would do is to trigger those tests manually in Yamato if you want to ensure that it's passing.
Otherwise notice that if there is a PR targeting develop branch to which you are merging then after the merge the tests will automatically run on that branch
Also fix/ may be a bit general in a way that someone may be surprised by enforced tests (in my opinion)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested fixes for the discovered DA only issue where non-authority instances would not automatically remove children from a parent
NetworkObjectbeing despawned by the authority.See: #3514
Changelog
NA
Testing and Documentation
Backport
No backport needed as this is all v2.x.