Hermes [ Crypto ] Fix first-depositor price manipulation in LiquidityPool#6011
Closed
Vincent1-p wants to merge 3 commits into
Closed
Hermes [ Crypto ] Fix first-depositor price manipulation in LiquidityPool#6011Vincent1-p wants to merge 3 commits into
Vincent1-p wants to merge 3 commits into
Conversation
…Pool Closes UnsafeLabs#918 - Add MINIMUM_LIQUIDITY=1000 lock at address(0) - Internal reserves instead of balanceOf for removeLiquidity - sync() function for donation recovery - SafeERC20 for all transfers - Comprehensive tests: 18 cases covering all acceptance criteria - First deposit lock verification - First-depositor manipulation prevention - Internal reserves for removeLiquidity - Sync event emission - Asymmetric deposits - Edge cases: boundary values, insufficient LP - Contributor verification: _generation.json
5dd77fd to
201c2b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #918
Changes
1. First-Depositor Attack Protection
MINIMUM_LIQUIDITY = 1000constantaddress(0)2. Internal Reserves
reserveAandreserveBinternal variablesremoveLiquidityuses internal reserves (not manipulablebalanceOf)3. Sync Function
sync()updates reserves from actual token balancesSyncevent for transparency4. SafeERC20 Integration
Testing (18 test cases)
Contributor Verification
_generation.jsonwith Hermes agent metadata/bounty 600