Add password #405
Closed
Add password #405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coniferish
force-pushed
the
fix_password
branch
from
f3c6d31 to
116184f
Compare
badGarnet
reviewed
Jan 21, 2025
| filename: str, | ||
| fixed_layouts: Optional[List[Optional[List[TextRegion]]]] = None, | ||
| pdf_image_dpi: int = 200, | ||
| password: Optional[str] = None, |
There was a problem hiding this comment.
the best practice is to avoid passing password as a plain text object since this leaves the password open for grabs. I'd suggest at least try hashing/encryption
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #392