PLUGINS-2225: Plugin steps updated to use Slack's OAuth. #11
Conversation
src/main/zip/plugin.xml
Outdated
| <properties> | ||
| <property name="webhook" required="true"> | ||
| <property-ui description="The Incoming WebHook URL that will accept external messages into Slack." label="Incoming WebHook" type="textBox"/> | ||
| <property name="oauthAccessToken" required="true"> |
There was a problem hiding this comment.
So we don't want to get rid of the webhook capabilities here. We still want that ability.
Please create a new plugin step that be called "Post Notification to Slack (With App Token)" or something like that. Then it would resemble what we have in the internal Slack repository.
We have to be careful in every change that we make that the existing functionality still works for people.
| return responseJson | ||
| } | ||
|
|
||
| def private executeIncomingWebhookPostMethod = {webhookURL, channel, message -> |
There was a problem hiding this comment.
I think it would replace much of the logic here?
https://github.com/UrbanCode/Slack-UCD/blob/master/src/main/zip/postToSlack.groovy
Options:
A) I'm okay with including this code, but you should likely comment it out or label its purpose so we know.
B) Update the code where you expect it to be used. (But likely should be done in a separate PR).
There was a problem hiding this comment.
New step that we have added, we are using only executePostMethod from SlackRestHelper.
Which i picked from slack ucd plugin (hcl github). We can remove it. Right now we are not using that method.
No description provided.