Skip to content

Chore: Drag and drop fixes, CRDT preparation, I18N message store refactor, etc. (#51, #60, #67, #74, #75, #80, #87, #88, 91) #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 41 commits into
base: master
Choose a base branch
from

Conversation

dev-guy
Copy link
Contributor

@dev-guy dev-guy commented Sep 18, 2023

Please Select Squash and Merge

Changes

Checklist

  • I imported the Kanban component based on this branch into another app and tested all features to the best of my ability

Notes

#60 - This additional PR expands on this PR to add CRDT-based multiuser functionality to svelte-kanban.

#74 - Dragging a card within a column behaves the same as dragging it into a different column. The behavior might feel a little clunky and unexpected because the dragged card is rendered as an empty rectangle so the user can tell where the card will return to if they drop the card off the board (in other words: cancel the drag and drop operation). To drag a card down, you have to drag it a long way! I prototyped alternative UX's but the code was complicated and I eventually decided that it was bad UX for drag-across versus drag-within to behave differently (as it did before this PR) - at least I couldn't come up with a good enough reason. After all, that's why I created #74 in the first place. The existing behavior is semi-unpredictable.

Screenshare.-.2023-09-19.2_12_26.PM.mp4

@dev-guy dev-guy marked this pull request as draft September 18, 2023 14:39
@dev-guy dev-guy changed the title CRDT refactor etc. (#60, ...) CRDT refactor etc. (#51, #60, #67, #75, #86) Sep 18, 2023
@dev-guy dev-guy changed the title CRDT refactor etc. (#51, #60, #67, #75, #86) CRDT refactor etc. (#51, #60, #67, #75) Sep 19, 2023
@dev-guy dev-guy changed the title CRDT refactor etc. (#51, #60, #67, #75) CRDT refactor etc. (#51, #60, #67, #75, #80) Sep 19, 2023
@dev-guy dev-guy changed the title CRDT refactor etc. (#51, #60, #67, #75, #80) Drag and drop enhancements, CRDT refactor, etc. (#51, #60, #67, #75, #80) Sep 19, 2023
@dev-guy dev-guy changed the title Drag and drop enhancements, CRDT refactor, etc. (#51, #60, #67, #75, #80) Drag and drop enhancements, CRDT refactor, etc. (#51, #60, #67, #75, #80, #87) Sep 19, 2023
@dev-guy dev-guy changed the title Drag and drop enhancements, CRDT refactor, etc. (#51, #60, #67, #75, #80, #87) Drag and drop enhancements, CRDT refactor, etc. (#51, #60, #67, #74, #75, #80, #87) Sep 19, 2023
@dev-guy dev-guy changed the title Drag and drop enhancements, CRDT refactor, etc. (#51, #60, #67, #74, #75, #80, #87) Drag and drop enhancements, CRDT refactor, etc. (#51, #60, #67, #74, #75, #80, #87, #88) Sep 19, 2023
@dev-guy dev-guy marked this pull request as ready for review September 19, 2023 21:15
@dev-guy dev-guy changed the title Drag and drop enhancements, CRDT refactor, etc. (#51, #60, #67, #74, #75, #80, #87, #88) Drag and drop enhancements, CRDT refactor, message store refactor, etc. (#51, #60, #67, #74, #75, #80, #87, #88) Sep 19, 2023
@dev-guy dev-guy changed the title Drag and drop enhancements, CRDT refactor, message store refactor, etc. (#51, #60, #67, #74, #75, #80, #87, #88) Drag and drop enhancements, refactor for CRDTs, message store refactor, etc. (#51, #60, #67, #74, #75, #80, #87, #88) Sep 21, 2023
@dev-guy dev-guy changed the title Drag and drop enhancements, refactor for CRDTs, message store refactor, etc. (#51, #60, #67, #74, #75, #80, #87, #88) Drag and drop enhancements, refactor for CRDTs, I18N store refactor, etc. (#51, #60, #67, #74, #75, #80, #87, #88) Sep 21, 2023
@dev-guy dev-guy changed the title Drag and drop enhancements, refactor for CRDTs, I18N store refactor, etc. (#51, #60, #67, #74, #75, #80, #87, #88) Drag and drop enhancements, CRDT refactor, message store refactor, etc. (#51, #60, #67, #74, #75, #80, #87, #88) Sep 21, 2023
@dev-guy dev-guy changed the title Drag and drop enhancements, CRDT refactor, message store refactor, etc. (#51, #60, #67, #74, #75, #80, #87, #88) Drag and drop enhancements, CRDT refactor, message store refactor, etc. (#51, #60, #67, #74, #75, #80, #87, #88, 91) Sep 21, 2023
@dev-guy dev-guy changed the title Drag and drop enhancements, CRDT refactor, message store refactor, etc. (#51, #60, #67, #74, #75, #80, #87, #88, 91) Chore: Drag and drop fixes, CRDT refactor, message store refactor, etc. (#51, #60, #67, #74, #75, #80, #87, #88, 91) Sep 21, 2023
@dev-guy dev-guy changed the title Chore: Drag and drop fixes, CRDT refactor, message store refactor, etc. (#51, #60, #67, #74, #75, #80, #87, #88, 91) Chore: Drag and drop fixes, CRDT refactor, I18N message store refactor, etc. (#51, #60, #67, #74, #75, #80, #87, #88, 91) Sep 21, 2023
@dev-guy dev-guy changed the title Chore: Drag and drop fixes, CRDT refactor, I18N message store refactor, etc. (#51, #60, #67, #74, #75, #80, #87, #88, 91) Chore: Drag and drop fixes, CRDT preparation, I18N message store refactor, etc. (#51, #60, #67, #74, #75, #80, #87, #88, 91) Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant