-
Notifications
You must be signed in to change notification settings - Fork 1
add search rules for eQTL and gene_trait queries #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think the tests are failing because of the jest configuration but I'm not sure how to fix it. |
Nice work @yudongqiu -- it appears to me the QueryBuilder js file is not properly being consumed by the typescript processor (querybuilder is written in TypeScript not plain javascript): So the way it works is: I checked out your branch and can replicate the error by running npm test, I'm playing around with it to see if I can get it to compile, but I think it's a path issue with the jest config as you pointed out. I just realized you have never worked with TypeScript before I assigned this task! |
@yudongqiu -- don't spend time on this -- it's a nasty config issue. I will try to fix it. |
The fix is to switch this line: TO:
The babel compiler isn't correctly configured to ingest es6 files which is why it breaks. The ts-jest compiler is already configured to do this so I'm not sure why we even had babel in the first place. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @yudongqiu
@yudongqiu with the rebase this should just work -- as we are no longer using the babel compiler |
This addresses later task in #118
Token
eqtl
is added to find all SNPs influencing to a certain gene.Token
genes
is added to find all genes that are intersecting with all variants that are influencing a certain trait. (There is a small issue that the keyword genes will pop the geneNames as choices due to regex matching. It may be solved by using a "unique" keyword, but I'm not exactly sure what is a good keyword)This PR also refactors the existing building query functions using the
QueryBuilder
class.