Skip to content

fix time remaining - #188

Merged
mitch10593 merged 2 commits into
mainfrom
fix/184-error-in-time-remaining-before-event-start
Jul 25, 2026
Merged

fix time remaining#188
mitch10593 merged 2 commits into
mainfrom
fix/184-error-in-time-remaining-before-event-start

Conversation

@mitch10593

@mitch10593 mitch10593 commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Summary by Sourcery

Improve calendar event time badges by using a shared, reactive time source and centralized formatting utilities.

New Features:

  • Add a reusable useNow composable that provides a reactive clock updated on a fixed interval.
  • Introduce shared date utilities for formatting time until an event and computing event status badges.

Bug Fixes:

  • Correct event "time remaining" display to show days, hours, or minutes without rounding up to whole days.
  • Ensure finished events are detected based on a reactive current time value so votes close at the right time.

Enhancements:

  • Refactor calendar and event detail views to use precomputed event badges backed by shared utilities instead of inline time calculations.

Documentation:

  • Update changelog with details about the new event badge behavior and time-remaining fixes.

Tests:

  • Add unit tests covering time-remaining formatting and event badge status transitions across edge cases.

@mitch10593 mitch10593 self-assigned this Jul 25, 2026
@mitch10593 mitch10593 linked an issue Jul 25, 2026 that may be closed by this pull request
@sourcery-ai

sourcery-ai Bot commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

🧙 Sourcery has finished reviewing your pull request!


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • In CalendarView.vue, consider typing eventBadges as computed(() => new Map<number, EventTimeBadge>(...)) to make the Map key and value types explicit and improve type safety around .get(event.id).
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- In `CalendarView.vue`, consider typing `eventBadges` as `computed(() => new Map<number, EventTimeBadge>(...))` to make the `Map` key and value types explicit and improve type safety around `.get(event.id)`.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@mitch10593
mitch10593 merged commit 99f11c6 into main Jul 25, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

error in time remaining before event start

1 participant