Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #10.
T_...
that we use_Interface
orInterface
for interface typesApplied change: using
_Interface
T_...
that we use something that is understood naturally without a secret decoder ring.Applied change: currently, there are no ordinary types in the packages, all are records defining an interface.
V_...
that we use_View
orView
Applied change: using
_View
For
..._In
also consider In as suffix (w/o _)."In" follows main data flow. Similar thoughts for ...Out
I2C_InView
vs.I2CViewIn
vs.I2CView_In
I2CInView
vs.I2C_In_View
vs.I2C_View_In
Applied change: using
_InView
and_OutView
respectively.For each interface there shall be a vector of that interface also declared of the form:
_Interface_Vector
Applied change: requirement was already fulfilled
_PCB
vs FPGA InternalsApplied change: PCB related signals use suffix
_PCB
, which fabric signal have no suffix.Review naming for AddressBus which historically was Master/Initiator and Slave/Target
Applied change: Different names chooses, if not dictated by the standard itself. If the standard changes naming, these definitions can be changed too.
AxiAddress should be unsigned.
Applied change: AXI is not part of this repo yet, will be applied when AXI is uploaded.
/cc @JimLewis see changes