some fixes after PR review

gmartina · gmartina · commit d5617f30c70b · 2025-11-22T19:33:58.000+01:00
diff --git a/tb/arith/RunAllTests.pro b/tb/arith/RunAllTests.pro
@@ -1,5 +1,6 @@
 # =============================================================================
 # Authors: Jonas Schreiner
+#          Gustavo Martin
 #
 # License:
 # =============================================================================
diff --git a/tb/arith/addw/RunAllTests.pro b/tb/arith/addw/RunAllTests.pro
@@ -1,5 +1,6 @@
 # =============================================================================
 # Authors: 
+#  Gustavo Martin
 #
 # License:
 # =============================================================================
diff --git a/tb/arith/addw/arith_addw_Simple.vhdl b/tb/arith/addw/arith_addw_Simple.vhdl
@@ -2,7 +2,8 @@
 -- vim: tabstop=2:shiftwidth=2:noexpandtab
 -- kate: tab-width 2; replace-tabs off; indent-width 2;
 -- =============================================================================
--- Authors:					
+-- Authors:					Thomas B. Preusser
+--                  Gustavo Martin
 --
 -- Entity:					arith_addw_Simple
 --
@@ -142,4 +143,4 @@ configuration arith_addw_Simple of arith_addw_TestHarness is
       use entity work.arith_addw_TestController(Simple);
     end for;
   end for;
-end configuration;
+end configuration;
diff --git a/tb/arith/addw/arith_addw_TestController.vhdl b/tb/arith/addw/arith_addw_TestController.vhdl
@@ -2,7 +2,8 @@
 -- vim: tabstop=2:shiftwidth=2:noexpandtab
 -- kate: tab-width 2; replace-tabs off; indent-width 2;
 -- =============================================================================
--- Authors:					
+-- Authors:					Thomas B. Preusser
+--                  Gustavo Martin
 --
 -- Entity:					arith_addw_TestController
 --
diff --git a/tb/arith/addw/arith_addw_TestController_pkg.vhdl b/tb/arith/addw/arith_addw_TestController_pkg.vhdl
@@ -2,7 +2,8 @@
 -- vim: tabstop=2:shiftwidth=2:noexpandtab
 -- kate: tab-width 2; replace-tabs off; indent-width 2;
 -- =============================================================================
--- Authors:					
+-- Authors:					Thomas B. Preusser
+--                  Gustavo Martin
 --
 -- Entity:					arith_addw_TestController_pkg
 --
@@ -48,4 +49,4 @@ package arith_addw_TestController_pkg is
   type word_vector is array(tArch_test, tSkip_test, boolean) of word;
   type carry_vector is array(tArch_test, tSkip_test, boolean) of std_logic;
 
-end package arith_addw_TestController_pkg;
+end package arith_addw_TestController_pkg;
diff --git a/tb/arith/addw/arith_addw_TestHarness.vhdl b/tb/arith/addw/arith_addw_TestHarness.vhdl
@@ -2,7 +2,8 @@
 -- vim: tabstop=2:shiftwidth=2:noexpandtab
 -- kate: tab-width 2; replace-tabs off; indent-width 2;
 -- =============================================================================
--- Authors:					
+-- Authors:					Thomas B. Preusser
+--                  Gustavo Martin
 --
 -- Entity:					arith_addw_TestHarness
 --
@@ -131,4 +132,4 @@ begin
       cout  => cout
     );
 
-end architecture;
+end architecture;
diff --git a/tb/arith/counter_bcd/RunAllTests.pro b/tb/arith/counter_bcd/RunAllTests.pro
@@ -1,6 +1,6 @@
 # =============================================================================
 # Authors: 
-#
+#   Gustavo Martin
 # License:
 # =============================================================================
 # Copyright 2025-2025 The PoC-Library Authors
diff --git a/tb/arith/counter_bcd/arith_counter_bcd_Simple.vhdl b/tb/arith/counter_bcd/arith_counter_bcd_Simple.vhdl
@@ -2,7 +2,9 @@
 -- vim: tabstop=2:shiftwidth=2:noexpandtab
 -- kate: tab-width 2; replace-tabs off; indent-width 2;
 -- =============================================================================
--- Authors:					
+-- Authors:					Martin Zabel
+--                  Thomas B. Preusser
+--                  Gustavo Martin
 --
 -- Entity:					arith_counter_bcd_Simple
 --
@@ -112,19 +114,15 @@ begin
     end loop;
     wait until falling_edge(Clock);
     inc      <= '1';
-    WaitForClock(Clock);
-    WaitForClock(Clock);
+    WaitForClock(Clock, 2);
     AffirmIf(ProcID, Value = (DIGITS - 1 downto 0 => x"0"), "Should be wrapped to 0000." & "  Value=" & to_string(Value));
 
     inc <= '1';
-    for j in 1 to 5 loop
-      WaitForClock(Clock);
-    end loop;
+    WaitForClock(Clock, 5);
 
     Reset_aux <= '1';
     inc <= '0';
-    WaitForClock(Clock);
-    WaitForClock(Clock);
+    WaitForClock(Clock, 2);
     AffirmIf(ProcID, Value = (DIGITS - 1 downto 0 => x"0"), "Should be resetted again.");
 
     -- Finalize
@@ -139,4 +137,4 @@ configuration arith_counter_bcd_Simple of arith_counter_bcd_TestHarness is
       use entity work.arith_counter_bcd_TestController(Simple);
     end for;
   end for;
-end configuration;
+end configuration;
diff --git a/tb/arith/counter_bcd/arith_counter_bcd_TestController.vhdl b/tb/arith/counter_bcd/arith_counter_bcd_TestController.vhdl
@@ -2,7 +2,9 @@
 -- vim: tabstop=2:shiftwidth=2:noexpandtab
 -- kate: tab-width 2; replace-tabs off; indent-width 2;
 -- =============================================================================
--- Authors:					
+-- Authors:					Martin Zabel
+--                  Thomas B. Preusser
+--                  Gustavo Martin
 --
 -- Entity:					arith_counter_bcd_TestController
 --
diff --git a/tb/arith/counter_bcd/arith_counter_bcd_TestHarness.vhdl b/tb/arith/counter_bcd/arith_counter_bcd_TestHarness.vhdl
@@ -2,7 +2,9 @@
 -- vim: tabstop=2:shiftwidth=2:noexpandtab
 -- kate: tab-width 2; replace-tabs off; indent-width 2;
 -- =============================================================================
--- Authors:					
+-- Authors:					Martin Zabel
+--                  Thomas B. Preusser
+--                  Gustavo Martin
 --
 -- Entity:					arith_counter_bcd_TestHarness
 --
@@ -103,4 +105,4 @@ begin
       inc       => inc,
       Value     => Value
     );
-end architecture;
+end architecture;
diff --git a/tb/arith/prefix_and/RunAllTests.pro b/tb/arith/prefix_and/RunAllTests.pro
@@ -2,10 +2,25 @@
 # Authors:
 #	Thomas B. Preusser
 #	Patrick Lehmann
+#   Gustavo Martin
+# =============================================================================
+# Copyright 2025-2025 The PoC-Library Authors
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
 # =============================================================================
 
 analyze arith_prefix_and_TestController.vhdl
 analyze arith_prefix_and_TestHarness.vhdl
 
 RunTest arith_prefix_and_Simple.vhdl
-RunTest arith_prefix_and_Exhaustive.vhdl
+RunTest arith_prefix_and_Exhaustive.vhdl
diff --git a/tb/arith/prefix_and/arith_prefix_and_Exhaustive.vhdl b/tb/arith/prefix_and/arith_prefix_and_Exhaustive.vhdl
@@ -2,7 +2,9 @@
 -- vim: tabstop=2:shiftwidth=2:noexpandtab
 -- kate: tab-width 2; replace-tabs off; indent-width 2;
 -- =============================================================================
--- Authors:					
+-- Authors:					Thomas B. Preusser
+--									Patrick Lehmann
+--                  Gustavo Martin
 --
 -- Entity:					arith_prefix_and_TestController
 --
diff --git a/tb/arith/prefix_and/arith_prefix_and_Simple.vhdl b/tb/arith/prefix_and/arith_prefix_and_Simple.vhdl
@@ -2,7 +2,9 @@
 -- vim: tabstop=2:shiftwidth=2:noexpandtab
 -- kate: tab-width 2; replace-tabs off; indent-width 2;
 -- =============================================================================
--- Authors:					
+-- Authors:					Thomas B. Preusser
+--									Patrick Lehmann
+--                  Gustavo Martin
 --
 -- Entity:					arith_prefix_and_TestController
 --
diff --git a/tb/arith/prefix_and/arith_prefix_and_TestController.vhdl b/tb/arith/prefix_and/arith_prefix_and_TestController.vhdl
@@ -2,7 +2,9 @@
 -- vim: tabstop=2:shiftwidth=2:noexpandtab
 -- kate: tab-width 2; replace-tabs off; indent-width 2;
 -- =============================================================================
--- Authors:					
+-- Authors:					Thomas B. Preusser
+--									Patrick Lehmann
+--                  Gustavo Martin
 --
 -- Entity:					arith_prefix_and_TestController
 --
diff --git a/tb/arith/prefix_and/arith_prefix_and_TestHarness.vhdl b/tb/arith/prefix_and/arith_prefix_and_TestHarness.vhdl
@@ -2,7 +2,9 @@
 -- vim: tabstop=2:shiftwidth=2:noexpandtab
 -- kate: tab-width 2; replace-tabs off; indent-width 2;
 -- =============================================================================
--- Authors:					
+-- Authors:					Thomas B. Preusser
+--									Patrick Lehmann
+--                  Gustavo Martin
 --
 -- Entity:					arith_prefix_and_TestHarness
 --
diff --git a/tb/arith/prefix_or/RunAllTests.pro b/tb/arith/prefix_or/RunAllTests.pro
@@ -2,6 +2,21 @@
 # Authors:
 #	Thomas B. Preusser
 #	Patrick Lehmann
+#   Gustavo Martin
+# =============================================================================
+# Copyright 2025-2025 The PoC-Library Authors
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
 # =============================================================================
 
 analyze arith_prefix_or_TestController.vhdl
diff --git a/tb/arith/prefix_or/arith_prefix_or_Exhaustive.vhdl b/tb/arith/prefix_or/arith_prefix_or_Exhaustive.vhdl
@@ -2,9 +2,10 @@
 -- vim: tabstop=2:shiftwidth=2:noexpandtab
 -- kate: tab-width 2; replace-tabs off; indent-width 2;
 -- =============================================================================
--- Authors:					
+-- Authors:			Thomas B. Preusser
+--                  Gustavo Martin
 --
--- Entity:					arith_prefix_or_TestController
+-- Entity:			arith_prefix_or_TestController
 --
 -- Description:
 -- -------------------------------------
diff --git a/tb/arith/prefix_or/arith_prefix_or_Simple.vhdl b/tb/arith/prefix_or/arith_prefix_or_Simple.vhdl
@@ -2,7 +2,8 @@
 -- vim: tabstop=2:shiftwidth=2:noexpandtab
 -- kate: tab-width 2; replace-tabs off; indent-width 2;
 -- =============================================================================
--- Authors:					
+-- Authors:					Thomas B. Preusser
+--                  Gustavo Martin
 --
 -- Entity:					arith_prefix_or_TestController
 --
diff --git a/tb/arith/prefix_or/arith_prefix_or_TestController.vhdl b/tb/arith/prefix_or/arith_prefix_or_TestController.vhdl
@@ -2,9 +2,10 @@
 -- vim: tabstop=2:shiftwidth=2:noexpandtab
 -- kate: tab-width 2; replace-tabs off; indent-width 2;
 -- =============================================================================
--- Authors:					
+-- Authors:			Thomas B. Preusser
+--                  Gustavo Martin
 --
--- Entity:					arith_prefix_or_TestController
+-- Entity:			arith_prefix_or_TestController
 --
 -- Description:
 -- -------------------------------------
diff --git a/tb/arith/prefix_or/arith_prefix_or_TestHarness.vhdl b/tb/arith/prefix_or/arith_prefix_or_TestHarness.vhdl
@@ -2,9 +2,10 @@
 -- vim: tabstop=2:shiftwidth=2:noexpandtab
 -- kate: tab-width 2; replace-tabs off; indent-width 2;
 -- =============================================================================
--- Authors:					
+-- Authors:			Thomas B. Preusser
+--                  Gustavo Martin
 --
--- Entity:					arith_prefix_or_TestHarness
+-- Entity:			arith_prefix_or_TestHarness
 --
 -- Description:
 -- -------------------------------------

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,6 @@`
`1`	`1`	`# =============================================================================`
`2`	`2`	`# Authors: Jonas Schreiner`
	`3`	`+# Gustavo Martin`
`3`	`4`	`#`
`4`	`5`	`# License:`
`5`	`6`	`# =============================================================================`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,6 @@`
`1`	`1`	`# =============================================================================`
`2`	`2`	`# Authors:`
	`3`	`+# Gustavo Martin`
`3`	`4`	`#`
`4`	`5`	`# License:`
`5`	`6`	`# =============================================================================`