Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Field Mill format #104

Merged
merged 3 commits into from
Feb 28, 2024
Merged

Added Field Mill format #104

merged 3 commits into from
Feb 28, 2024

Conversation

eaeyal
Copy link
Contributor

@eaeyal eaeyal commented Feb 25, 2024

Created format for the new Field Mill sensor.

@eaeyal eaeyal requested a review from panyab February 25, 2024 23:00
@eaeyal eaeyal self-assigned this Feb 25, 2024
panyab
panyab requested changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@panyab panyab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change min/max values

panyab
panyab approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@panyab panyab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@panyab panyab self-requested a review February 27, 2024 20:57
panyab
panyab requested changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@panyab panyab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you bump the version in setup.py

panyab
panyab approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@panyab panyab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@panyab panyab merged commit 67e89b3 into main Feb 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panyab panyab panyab approved these changes

Assignees

@eaeyal eaeyal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eaeyal @panyab