Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add validity check for packet formats #86

Merged
merged 2 commits into from
Nov 10, 2023
Merged

add validity check for packet formats #86

merged 2 commits into from
Nov 10, 2023

Conversation

VanL15
Copy link
Contributor

@VanL15 VanL15 commented Nov 10, 2023

Added a check in packet.py for checking if a format is valid. Added an abstract method to BaseFormat for get_validity.

@VanL15 VanL15 requested a review from aryanbattula November 10, 2023 02:36
aryanbattula
aryanbattula previously approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@aryanbattula aryanbattula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks right

aryanbattula
aryanbattula approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@aryanbattula aryanbattula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aryanbattula aryanbattula merged commit 847f9fe into main Nov 10, 2023
@VanL15 VanL15 linked an issue Nov 10, 2023 that may be closed by this pull request
Change packet.py to check for format validity #85
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aryanbattula aryanbattula aryanbattula approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change packet.py to check for format validity
2 participants
@VanL15 @aryanbattula