Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

60 base sensors #72

Merged
merged 71 commits into from
Jul 7, 2023
Merged

60 base sensors #72

merged 71 commits into from
Jul 7, 2023

Conversation

David-Rey
Copy link
Contributor

No description provided.

@thomasmholder thomasmholder self-requested a review July 4, 2023 01:16
thomasmholder
thomasmholder requested changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@thomasmholder thomasmholder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, wasn't sure what is/isn't in scope

@DarylDohner DarylDohner requested a review from thomasmholder July 4, 2023 16:21
thomasmholder
thomasmholder previously approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@thomasmholder thomasmholder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks "good" to me

@thomasmholder thomasmholder self-requested a review July 6, 2023 02:01
thomasmholder
thomasmholder previously approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@thomasmholder thomasmholder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@thomasmholder thomasmholder self-requested a review July 7, 2023 03:04
thomasmholder
thomasmholder approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@thomasmholder thomasmholder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the everything this looks good

DarylDohner
DarylDohner approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@DarylDohner DarylDohner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm daryl dohner and i approve these changes

@DarylDohner DarylDohner merged commit 43983ac into main Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarylDohner DarylDohner DarylDohner approved these changes

@thomasmholder thomasmholder thomasmholder approved these changes

Assignees
No one assigned
Labels
driver task related to any non-radio/non-telemetry driver
Projects
None yet
Milestone
2023 Spring
Development

Successfully merging this pull request may close these issues.
3 participants
@David-Rey @DarylDohner @thomasmholder