Add automated problem type voting

If the number of distinct voters exceeds VNOJ_PROBLEM_TYPE_VOTING_VOTERS_THRESHOLD: - Sort the votes of each type in descending order - Filter the types whose number of votes exceeds VNOJ_PROBLEM_TYPE_VOTING_VOTES_LOWERBOUND - Get the first VNOJ_PROBLEM_TYPE_VOTING_TYPES_UPPERBOUND records
VNOI-Admin · Apr 9, 2024 · 9438621 · 9438621
1 parent 7a4cc9d
commit 9438621
Show file tree

Hide file tree

Showing 6 changed files with 49 additions and 2 deletions.
diff --git a/dmoj/settings.py b/dmoj/settings.py
@@ -104,6 +104,10 @@
 VNOJ_CONTEST_CHEATING_BAN_MESSAGE = 'Banned for multiple cheating offenses during contests'
 VNOJ_MAX_DISQUALIFICATIONS_BEFORE_BANNING = 3
 
+VNOJ_PROBLEM_TYPE_VOTING_VOTERS_THRESHOLD = 10
+VNOJ_PROBLEM_TYPE_VOTING_VOTES_LOWERBOUND = 4
+VNOJ_PROBLEM_TYPE_VOTING_TYPES_UPPERBOUND = 3
+
 # List of subdomain that will be ignored in organization subdomain middleware
 VNOJ_IGNORED_ORGANIZATION_SUBDOMAINS = ['oj', 'www', 'localhost']
 

diff --git a/judge/admin/problem.py b/judge/admin/problem.py
@@ -131,7 +131,7 @@ class ProblemAdmin(NoBatchDeleteMixin, VersionAdmin):
             ),
         }),
         (_('Social Media'), {'classes': ('collapse',), 'fields': ('og_image', 'summary')}),
-        (_('Taxonomy'), {'fields': ('types', 'allow_type_voting', 'group')}),
+        (_('Taxonomy'), {'fields': ('types', 'allow_type_voting', 'automated_type_voting', 'group')}),
         (_('Points'), {'fields': (('points', 'partial'), 'short_circuit')}),
         (_('Limits'), {'fields': ('time_limit', 'memory_limit')}),
         (_('Language'), {'fields': ('allowed_languages',)}),

diff --git a/judge/forms.py b/judge/forms.py
@@ -188,6 +188,7 @@ def __init__(self, *args, **kwargs):
 
         if not manage_type_voting:
             self.fields.pop('allow_type_voting')
+            self.fields.pop('automated_type_voting')
 
         self.fields['testers'].help_text = \
             str(self.fields['testers'].help_text) + ' ' + \
@@ -230,7 +231,7 @@ class Meta:
         model = Problem
         fields = ['is_public', 'code', 'name', 'time_limit', 'memory_limit', 'points', 'partial',
                   'statement_file', 'source', 'types', 'group', 'submission_source_visibility_mode',
-                  'testcase_visibility_mode', 'description', 'testers', 'allow_type_voting']
+                  'testcase_visibility_mode', 'description', 'testers', 'allow_type_voting', 'automated_type_voting']
         widgets = {
             'types': Select2MultipleWidget,
             'group': Select2Widget,

diff --git a/judge/migrations/0205_automated_problem_type_voting.py b/judge/migrations/0205_automated_problem_type_voting.py
@@ -0,0 +1,19 @@
+# Generated by Django 3.2.23 on 2024-03-24 05:22
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('judge', '0204_problem_type_voting'),
+    ]
+
+    operations = [
+        migrations.AddField(
+            model_name='problem',
+            name='automated_type_voting',
+            field=models.BooleanField(default=True, help_text='Automatically set problem types based on '
+                                                              'a certain threshold of votes.'),
+        ),
+    ]
diff --git a/judge/models/problem.py b/judge/models/problem.py
@@ -222,6 +222,9 @@ class Problem(models.Model):
 
     allow_type_voting = models.BooleanField(default=False, help_text=_('Allow public voting on problem types.'))
 
+    automated_type_voting = models.BooleanField(default=True, help_text=_('Automatically set problem types based on '
+                                                                          'a certain threshold of votes.'))
+
     allow_view_feedback = models.BooleanField(
         help_text=_('Allow user to view checker feedback.'),
         default=False,

diff --git a/judge/views/problem.py b/judge/views/problem.py
@@ -1087,6 +1087,26 @@ def form_valid(self, form):
                 problem_type=problem_type,
             ) for problem_type in new_types)
 
+            if self.object.automated_type_voting:
+                voters = ProblemTypeVote.objects.filter(problem=self.object).values('user').distinct().count()
+                if voters >= settings.VNOJ_PROBLEM_TYPE_VOTING_VOTERS_THRESHOLD:
+                    # If the number of distinct voters exceeds VNOJ_PROBLEM_TYPE_VOTING_VOTERS_THRESHOLD:
+                    #   - Sort the votes of each type in descending order
+                    #   - Filter the types whose number of votes exceeds VNOJ_PROBLEM_TYPE_VOTING_VOTES_LOWERBOUND
+                    #   - Get the first VNOJ_PROBLEM_TYPE_VOTING_TYPES_UPPERBOUND records
+                    problem_types = (
+                        ProblemType.objects.annotate(votes=Count('problemtypevote',
+                                                                 filter=Q(problemtypevote__problem=self.object)))
+                                           .order_by('-votes')
+                                           .filter(votes__gte=settings.VNOJ_PROBLEM_TYPE_VOTING_VOTES_LOWERBOUND)
+                        [:settings.VNOJ_PROBLEM_TYPE_VOTING_TYPES_UPPERBOUND])
+                    self.object.types.add(*problem_types)
+
+                    # Disable public voting
+                    self.object.allow_type_voting = False
+
+                    self.object.save()
+
         return super().form_valid(form)
 
     def form_invalid(self, form):