remove docker-maven-plugin #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current version of the docker-maven-plugin is no longer supported, and causes issues with docker hosts where the daemon is not reachable via TCP. Since integrating docker with the maven build is not currently needed in development, this feature is now completely removed.
|
Integration testing still needs to be sorted out |
Previous commit removed spotify's docker-maven-plugin for building, but fabric8's docker-maven-plugin still remains for integration tests. This commit bumps up the plugin version to 0.38.1, which should work with docker using a socket file. Elasticsearch version is also updated to the same (but still old) version that is used by the docker-compose setup in the project.
kkyttala
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of the docker-maven-plugin is no longer supported, and causes issues with docker hosts where the daemon is not reachable via TCP.
Since integrating docker with the maven build is not currently needed in development, this feature is now completely removed.