Skip to content

Add config to pop balloons in the nether - #435

Open
dbyale wants to merge 13 commits into
ValkyrienSkies:1.18.x/mainfrom
dbyale:EnderBoy9217-nether-pop
Open

Add config to pop balloons in the nether#435
dbyale wants to merge 13 commits into
ValkyrienSkies:1.18.x/mainfrom
dbyale:EnderBoy9217-nether-pop

Conversation

@dbyale

@dbyale dbyale commented Dec 30, 2024

Copy link
Copy Markdown
Contributor

If a balloon is placed in the nether with the config enabled, it immediately destroys itself exactly as it would if a projectile hit it, and does not report that a balloon was added to the ship.

No change if the config is disabled.

Another balancing change to make the nether a more hostile environment in survival worlds. While it still allows for the creation of ships, it effectively limits these ships to lava lakes, instead of simply allowing you to park your mobile base on top of a nether fortress and feel safe.

Config is disabled by default.

@millennIumAMbiguity

Copy link
Copy Markdown
Collaborator

It would be nice to have a config for setting what dimensions this occures in.

@dbyale

dbyale commented Dec 30, 2024

Copy link
Copy Markdown
Contributor Author

It would be nice to have a config for setting what dimensions this occures in.

Done
Also added more smoke effects to make it more clear to the user that balloons can't be placed, rather than look like they bugged

@millennIumAMbiguity

Copy link
Copy Markdown
Collaborator

I think the hotBalloonHeatMultiplier should be removed as the feature is disabled by removing all items in the list.
By default, the list should be empty.
Additionally, we can optimize it a bit by skipping detention checks if the list is empty.

Comment thread common/src/main/kotlin/org/valkyrienskies/eureka/EurekaConfig.kt Outdated
Comment thread common/src/main/kotlin/org/valkyrienskies/eureka/EurekaConfig.kt Outdated
Comment thread common/src/main/kotlin/org/valkyrienskies/eureka/EurekaConfig.kt Outdated
dbyale and others added 4 commits March 26, 2025 15:00
Uninclude the nether as default
give an example
remove the boolean config
Remove nether as default and remove boolean config
@dbyale

dbyale commented Apr 15, 2025

Copy link
Copy Markdown
Contributor Author

Requested changes have been implemented

Removed Unnecessary Logger which could cause issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants