Add unit-tests and initialises integration-test#12
Open
NeerajGartia21 wants to merge 1 commit intoVallariAg:mainfrom
Open
Add unit-tests and initialises integration-test#12NeerajGartia21 wants to merge 1 commit intoVallariAg:mainfrom
NeerajGartia21 wants to merge 1 commit intoVallariAg:mainfrom
Conversation
kamoltat
requested changes
Mar 20, 2023
Collaborator
kamoltat
left a comment
There was a problem hiding this comment.
Please also add unit test for a function in src/services/kill.py. Please sign your commit using git commit -s. Also please drop the changes you have made on existing code, if you want to change something then, please file a separate PR. We only ask you to add unit-test in the assignment. 🙂
Collaborator
|
Please rebase. |
VallariAg
pushed a commit
that referenced
this pull request
Jun 13, 2024
Authentication callback Reviewed-by: Kamoltat Sirivadhna <ksirivad@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds unit-tests and initialises integration-tests.
Proposed folder structure :
In this PR :
Next Tasks :
Note- Since it is good to have atomic commits, I will be adding unit-tests for different components in separate commits.