Skip to content

Add unit-tests and initialises integration-test#12

Open
NeerajGartia21 wants to merge 1 commit intoVallariAg:mainfrom
NeerajGartia21:unit-test
Open

Add unit-tests and initialises integration-test#12
NeerajGartia21 wants to merge 1 commit intoVallariAg:mainfrom
NeerajGartia21:unit-test

Conversation

@NeerajGartia21
Copy link

This PR adds unit-tests and initialises integration-tests.

Proposed folder structure :

--- tests
      |---integration
      |---unit
            |---test_suite_route.py
                  .....
      |---utils
            |---mocker.py
                 .....
      ---conftest.py

In this PR :

  • pytest is used for unit-testing.
  • pytest-mock is used for mocking dependencies.

Next Tasks :

  • Adding Integration-tests.
  • Adding CI for GitHub actions.

Note- Since it is good to have atomic commits, I will be adding unit-tests for different components in separate commits.

Copy link
Collaborator

@kamoltat kamoltat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add unit test for a function in src/services/kill.py. Please sign your commit using git commit -s. Also please drop the changes you have made on existing code, if you want to change something then, please file a separate PR. We only ask you to add unit-test in the assignment. 🙂

@kamoltat
Copy link
Collaborator

Please rebase.

VallariAg pushed a commit that referenced this pull request Jun 13, 2024
Authentication callback
Reviewed-by: Kamoltat Sirivadhna <ksirivad@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants