Add unit test for API endpoints using TestClient library from fast-api#13
Open
Dorcas-BD wants to merge 4 commits intoVallariAg:mainfrom
Open
Add unit test for API endpoints using TestClient library from fast-api#13Dorcas-BD wants to merge 4 commits intoVallariAg:mainfrom
Dorcas-BD wants to merge 4 commits intoVallariAg:mainfrom
Conversation
kamoltat
requested changes
Mar 20, 2023
Collaborator
kamoltat
left a comment
kamoltat
left a comment
There was a problem hiding this comment.
Please also add a unit-test for 1 func in src/services/kill.py
Collaborator
|
Please also sign your commit using |
Author
Alright, I will do that @kamoltat |
…api/add-endpoint-unit-tests
…ng TestClient library from fast-api Signed-off-by: Dorcas Bamisile <[email protected]>
Author
|
Hello @kamoltat, I wanted to let you know that I've added unit tests for src/services/kill.py and signed my commit. Can you please review it? |
Signed-off-by: Dorcas Bamisile <[email protected]>
Author
|
Hello @kamoltat, I have pushed a commit for my Task 3. Please review it and provide me with your feedback or suggestions. Additionally, if you haven't had a chance to review my Task 2 yet, please also look at that. Thank you in advance for your help. cc: @amathuria @zmc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added unit tests for API endpoints using FastAPI's TestClient library to ensure correct responses and improve application quality. Used TestClient to make HTTP requests, wrote test functions for various use cases and checked for correct status codes, headers, and response bodies. Please review @amathuria @kamoltat @zmc