Restore PR #611 fixes and stabilize test suite#756
Restore PR #611 fixes and stabilize test suite#756isasardar1-coder wants to merge 2 commits intoValueCell-ai:mainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5b187a6561
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| writeFileSync(join(OUTPUT_ROOT, '.preinstalled-lock.json'), `${JSON.stringify(lock, null, 2)}\n`, 'utf8'); | ||
| rmSync(TMP_ROOT, { recursive: true, force: true }); | ||
| echo`Preinstalled skills ready: ${OUTPUT_ROOT}`; | ||
| console.log('Skipping preinstalled skills bundle on Windows...'); |
There was a problem hiding this comment.
This script is now an unconditional no-op, so every platform skips generating build/preinstalled-skills despite build/package invoking it (package.json scripts). That means preinstalled skills are never copied into artifacts, and release packaging is at risk because electron-builder.yml still declares build/preinstalled-skills/ as an extraResources source. Please restore the actual bundling flow (or gate the skip behind a real Windows-only/environment check).
Useful? React with 👍 / 👎.
1 participant
Summary
This restores the
Sidebar project folders and multi-agent chat UIwork from PR #611 onto a fresh checkout and adds the follow-up fixes needed to make the branch safe to validate again.af2aee9Why
The original local implementation was erased after an app update, but PR #611 still contained the branch diff. After restoring it, there were three known regressions plus a broader set of failing unit tests caused by environment and expectation drift.
This PR gets the restored branch back to a healthy, reviewable state.
Validation
pnpm run build:vitepnpm run typecheckpnpm exec vitest runCurrent result:
Notes
Multi-agent behavior remains toolbar-driven in the chat window:
AgentssectionChatToolbarRelated