Skip to content

feat(cron): enable WeChat as a supported delivery channel#789

Merged
su8su merged 4 commits intomainfrom
feat/weixin_cron
Apr 7, 2026
Merged

feat(cron): enable WeChat as a supported delivery channel#789
su8su merged 4 commits intomainfrom
feat/weixin_cron

Conversation

@su8su
Copy link
Copy Markdown
Contributor

@su8su su8su commented Apr 7, 2026

Summary

Related Issue(s)

Closes #761

Type of Change

  • Bug fix
  • New feature
  • Documentation
  • Refactor
  • Other

Validation

Checklist

  • I ran relevant checks/tests locally.
  • I updated docs if behavior or interfaces changed.
  • I verified there are no unrelated changes in this PR.

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 106ad80109

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

}

const TESTED_CRON_DELIVERY_CHANNELS = new Set<string>(['feishu', 'telegram', 'qqbot', 'wecom']);
const TESTED_CRON_DELIVERY_CHANNELS = new Set<string>(['feishu', 'telegram', 'qqbot', 'wecom', 'wechat']);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep WeChat excluded until backend accepts cron delivery

Adding wechat to the supported channel allowlist makes the UI treat it as selectable/savable, but cron creation still hard-fails in the host API: getUnsupportedCronDeliveryError in electron/api/routes/cron.ts returns a WeChat-specific error and both POST/PUT handlers reject with HTTP 400 for announce mode. In practice, selecting WeChat in this dialog now leads users into a save path that is guaranteed to fail, so the feature advertised by this change is non-functional.

Useful? React with 👍 / 👎.

@su8su su8su mentioned this pull request Apr 7, 2026
2 tasks
@su8su su8su merged commit 3021ad5 into main Apr 7, 2026
6 checks passed
@su8su su8su deleted the feat/weixin_cron branch April 7, 2026 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

定时任务通道选择微信

1 participant