Skip to content

vgui_controls: Prevent use-after-free for m_pResourcePathID when LoadControlSettings for BuildGroup #1652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

vgui_controls: Prevent use-after-free for m_pResourcePathID when LoadControlSettings for BuildGroup #1652

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/vgui2/vgui_controls/BuildGroup.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -987,7 +987,8 @@ void BuildGroup::LoadControlSettings(const char *controlResourceName, const char
m_pResourceName = new char[strlen(controlResourceName) + 1];
strcpy(m_pResourceName, controlResourceName);

if (pathID)
// set path id only if it is not the same to prevent use-after-free
if (pathID && pathID != m_pResourcePathID)
{
delete [] m_pResourcePathID;
m_pResourcePathID = new char[strlen(pathID) + 1];
Expand Down