[TF2] Fix an assertion error from trying to remove a nonexistent particle effect #1658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r when cloaked Because the particle effect "balloontoss_drip" does not exist in TF2's files, this call causes an assertion error in clients whenever a Spy begins cloaking. Commenting out this call prevents this error from occurring.
copperpixel
reviewed
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The following function call causes an assertion error whenever a Spy begins to cloak in TF2:
source-sdk-2013/src/game/shared/tf/tf_player_shared.cpp
Line 7003 in b2705ba
This call causes an assertion error because TF2 does not have any particle definition named
balloontoss_drip; in fact, this is the only line in the SDK that references such a particle effect. Since this particle effect has no definition and is never created, this function call effectively does nothing. (This was likely related to a scrapped water balloon weapon that was never fully implemented.)This PR prevents this assertion error by commenting out the offending function call.