[TF2] Fixed Exorcism not working properly for the Stickybomb launcher and Ullapool Caber's explosion kills #1660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llapool Caber's explosion kills Fixes: ValveSoftware/Source-1-Games#7692 ValveSoftware/Source-1-Games#7380 Changed the way the Exorcism spell particle is dispatched, the previous DispatchParticleEffect has issues with Exorcism on certain weapons for whatever reason, but changing the code to TE_TFParticleEffect seems to fix these issues completely. As a bonus, this also fixes weapons with taunt kills, so any Exorcism taunt kill weapons will now also affect the taunt kill aswell.
FrozenDragon0
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the Exorcism Halloween spell not working properly for Stickybomb launchers and the Ullapool Caber's explosion kills
Fixes:
ValveSoftware/Source-1-Games#7692
ValveSoftware/Source-1-Games#7380
Changed the way the Exorcism spell particle is dispatched, the previous DispatchParticleEffect has issues with Exorcism on certain weapons for whatever reason, seems to be some sort of client and server sync issues, I'm not 100% sure, but changing the code to TE_TFParticleEffect seems to fix these issues completely.
For those un-aware, the vanilla game currently, Exorcism is bugged on the stickybomb launcher and will not show the ghosts for the player who achieved the kill, however the ghosts show up for everyone else just fine, if the kill was made by firing a 9th sticky and the 1st stickybomb detonates killing someone, then the ghosts appear for the killer as expected.
As for the Ullapool Caber, it's a somewhat similar scenario, but instead the ghosts don't appear for the killer if the kill in question was done via the caber's explosion even though other players and the victim can see it.
ULLAPOOL_CABER_EXPLOSIONin console to know if the caber's kill was an explosion or not.As a bonus, this also fixes weapons with taunt kills, so any taunt kills made with a weapon that has Exorcism applied It'll show the ghosts for the taunt kill aswell. This goes for numerous taunt kills, such as Demoman's decapitation taunt with the various swords, or the Engineer's Frontier Justice Guitar smash kill.
Fixed behavior with the stickybomb launcher:
stickybomb_fix.mp4