fix[Closes #427]: Only show "Retry connection" button after a failure and skip over connection test page when navigating backwards

[acerspyro]

Work to do:

• Do not show "Retry connection" button until a failure has occurred
• Edit awkward wording on connection test page (Open to suggestions)
• Skip over the connection test page when navigating backwards

[acerspyro]

I'm open to suggestions on how to skip over the connection test page only when navigating backwards.

From my read of the code, it doesn't seem like pages currently have knowledge of which page comes before or after them, simply that they must navigate to the next ID. This is problematic for this case unless we decide to only perform the connection check once, which may be undesirable.

[acerspyro]

Screencast.From.2024-12-01.23-56-34.mp4

Behaves as expected now.

[taukakao]

I think only automatically skipping forward once is acceptable here.

[acerspyro]

I think only automatically skipping forward once is acceptable here.

I'm not sure I understand what you mean.

The original issue states that, since the connection test page navigates forwards automatically, it makes it difficult to return to the "language" or "welcome" pages when using the back button to navigate as you will be automatically booted back to the next page.

This is more about skipping over the connection test page when navigating backwards (but not forwards).

[taukakao]

This is more about skipping over the connection test page when navigating backwards (but not forwards).

Yes, I would suggest the installer skips to the next page after the check is complete but then remembers that and doesn't skip a second time, no matter what direction the user is going.

(That might require a "check successful" text though, to not be confusing)

[acerspyro]

This is more about skipping over the connection test page when navigating backwards (but not forwards).

Yes, I would suggest the installer skips to the next page after the check is complete but then remembers that and doesn't skip a second time, no matter what direction the user is going.

(That might require a "check successful" text though, to not be confusing)

An interesting solution.

This would definitely resolve the navigation issue, although I feel like at this point, the page could simply be hidden from navigation as it is no longer useful, but that might be harder to implement than your more straightforward solution and would involve a skipping mechanism.