Disable SDL2 and ffplay when ENABLE_FFPLAY is false to eliminate unwanted SDL2 linkage#39
Open
NicolasReibnitz wants to merge 2 commits into
Open
Disable SDL2 and ffplay when ENABLE_FFPLAY is false to eliminate unwanted SDL2 linkage#39NicolasReibnitz wants to merge 2 commits into
NicolasReibnitz wants to merge 2 commits into
Conversation
…nted SDL2 linkage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building with
ENABLE_FFPLAY=false(the default), the scripts only omitted the--enable-sdl2flag, but didn’t explicitly disable SDL2 or ffplay. As a result, pkg-config still detected SDL2 and injected a/opt/homebrew/.../libSDL2-2.0.0.dylibdependency into the “static” binary.This PR adds an else branch in both
build-ffmpeg.shandbuild-ffmpeg-topaz.shso that whenever ENABLE_FFPLAY is not TRUE, we pass--disable-sdl2 --disable-ffplayto ./configure.Verification:
After rebuilding with
ENABLE_FFPLAY=false:no longer lists any SDL2 dylib, only system frameworks under
/System/Library/…and/usr/lib/.