feat(dashboard): fix #8 replace vault leaderboard placeholder with in…#66
Merged
BigDella merged 1 commit intoJul 22, 2026
Conversation
…er with indexed data
Contributor
|
@Owolabenjade great job love this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
components/app/VaultLeaderboardPlaceholder.jsx) with a production-grade, indexed saver leaderboard (VaultLeaderboard).types/leaderboard.ts(LeaderboardEntry,LeaderboardFilterOptions,LeaderboardResponse,RankState).services/leaderboardService.tsproviding API data fetching, deterministic score sorting (sortLeaderboardEntries), local dev fallback, and privacy-conscious address formatting (formatPrivacyAddressfor StellarGABC...XYZand EVM0x12...5678).GET /actions/leaderboardinbackend/src/routes/actions.ts.components/app/VaultLeaderboard.test.jsxtesting sorting order, address formatting, and UI state rendering.Linked Issue
Validation
npm run lintnpm run buildpnpm auditrun for dependenciesnpx vitest run components/app/VaultLeaderboard.test.jsx(All address formatting, score sorting, and UI state tests passed).Notes