Feat/profile - #84
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Added validation schema: Added
updateProfileSchemain auth.validator.ts that validates optional firstName, lastName, and uses the existing phoneNumberField to normalize and validate phone numbers.Added updateProfile service method: Added
updateProfilein auth.service.ts that:Added controller method: Added
updateProfilein auth.controller.ts that handles the request, extracts the user ID from the authenticated request, calls the service, and returns the response.Added the route: Added
PUT /api/v1/auth/profilein auth.routes.ts that uses the authenticate middleware and the new updateProfileSchema validator.Created integration tests: Created profile.integration.test.ts that tests:
All acceptance criteria have been met! The implementation preserves uniqueness (since phoneNumber is unique in the DB and we check before updating), is audit-safe (since Prisma's updatedAt is automatically updated, and we don't allow changing immutable fields), and all validations are in place.
Closes #77