Feat/transac - #93
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✅ All requirements met:
1. Transaction notification system
TransactionNotificationandTransactionStatusTypetypes to support pending, success, error, and dismissed statusesaddTransactionNotification: Creates notifications with duplicate prevention via idempotency keysupdateTransactionNotification: Updates existing notificationsdismissTransactionNotification: Marks notifications as dismissedremoveTransactionNotification: Cleans up dismissed notificationsfindNotificationByIdempotencyKey: Prevents duplicate notifications2. UI Components
3. Accessibility features
aria-liveregions4. Integration with vault mutations
Updated all vault operations in useVault.ts to use the notification system:
createVault: Shows "Creating your vault..." → "Vault created successfully!"depositToVault: Shows "Processing deposit..." → "Successfully deposited..."withdrawFromVault: Shows "Processing withdrawal..." → "Successfully withdrew..."lockVault: Shows "Locking your vault..." → "Vault locked successfully!"unlockVault: Shows "Unlocking your vault..." → "Vault unlocked successfully!"closeVault: Shows "Closing your vault..." → "Vault closed successfully!"5. Smart features
6. Global availability
Added the TransactionToast component to the root layout.tsx so it's available throughout the entire app, and added the necessary CSS for screen readers in globals.css.
The system is now ready to be extended to funding, lending, and borrowing transactions in the future, as it's built to support all those transaction types out of the box.
closes #79