Fix: Replace hardcoded local path for CLIP text model with Hugging Fa…#203
Open
uttkxrrsh wants to merge 1 commit into
Open
Fix: Replace hardcoded local path for CLIP text model with Hugging Fa…#203uttkxrrsh wants to merge 1 commit into
uttkxrrsh wants to merge 1 commit into
Conversation
…ce identifier ### Description This PR addresses an issue in the YOLO-World XL configuration file (`yolo_world_v2_xl_vlpan_bn_2e-3_100e_4x8gpus_obj365v1_goldg_train_lvis_minival.py`) where the `text_model_name` was hardcoded to a local absolute path (`/mnt/petrelfs/...`). Leaving this hardcoded breaks the execution for anyone cloning the repository and attempting to run the configuration on their local machines or alternative compute clusters, resulting in a `FileNotFoundError`. ### Changes Made * Restored `'openai/clip-vit-base-patch32'` as the default `text_model_name`. This ensures the Hugging Face `transformers` library can automatically fetch and cache the model weights, making the script plug-and-play for new users. * Commented out the local paths. Users running this on isolated compute nodes (e.g., via Slurm) can still easily override this variable in their local workflows to point to pre-downloaded checkpoints. ### Testing * Verified that setting `text_model_name = 'openai/clip-vit-base-patch32'` correctly initializes the HuggingCLIPLanguageBackbone without requiring a pre-existing local directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ce identifier
Description
This PR addresses an issue in the YOLO-World XL configuration file (
yolo_world_v2_xl_vlpan_bn_2e-3_100e_4x8gpus_obj365v1_goldg_train_lvis_minival.py) where thetext_model_namewas hardcoded to a local absolute path (/mnt/petrelfs/...).Leaving this hardcoded breaks the execution for anyone cloning the repository and attempting to run the configuration on their local machines or alternative compute clusters, resulting in a
FileNotFoundError.Changes Made
'openai/clip-vit-base-patch32'as the defaulttext_model_name. This ensures the Hugging Facetransformerslibrary can automatically fetch and cache the model weights, making the script plug-and-play for new users.Testing
text_model_name = 'openai/clip-vit-base-patch32'correctly initializes the HuggingCLIPLanguageBackbone without requiring a pre-existing local directory.