Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/windows pip package #7

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Conversation

Vdaleke
Copy link
Owner

@Vdaleke Vdaleke commented Jan 26, 2025

No description provided.

@Vdaleke Vdaleke force-pushed the feature/windows-pip-package branch 8 times, most recently from 5196902 to 2683a83 Compare January 26, 2025 18:32
@Vdaleke Vdaleke marked this pull request as ready for review January 26, 2025 18:36
p-senichenkov and others added 11 commits January 26, 2025 21:41
- Add `set -e` in build.sh to stop build process on error
- Add SYSTEM property to all `add_subdirectory` commands that add
  external dependencies to avoid compiler warnings that aren't related
  to Desbordante
- Disable alloc-dealloc-mismatch check as it's false positive
  on Ubuntu (see comment in CMakeLists.txt)
- Limit UB sanitizer "function" check to only our code when building with
  Clang on macOS (see comment in CMakeLists.txt)
- Update googletest version from 1.13.0 to 1.14.0, because 1.13.0 produces "narrowing conversion" warning due to a bug
  (issue #4206, google/googletest#4206) when building
  with Clang. This bug was fixed in 1.14.0 (commit 3044657,
  google/googletest@3044657)
- Disable deprecated-declaration warning on Clang-18 (see comment in CMakeLists.txt)
Fix Clang warnings and UB and ADDRESS sanitizer errors:
- Replace INSTANTIATE_TEST_CASE_P, which is deprecated, with INSTANTIATE_TEST_SUITE_P
  in NDVerifier tests
- Mark unused fields as [[maybe_unused]]. Use MAYBE_UNUSED_PRIVATE_FIELD macro, because GCC produces
  warning when [[maybe_unused]] attribute is present, and Clang -- when it isn't.
  (see comment in util/maybe_unused_on_clang.h)
- Convert double literals to model::DoubleType and model::IntType explicitly in tests/test_types.cpp
- Check that column is numeric *before* casting it to INumericType in DataStats::GetMedianAD
- Don't process empty vector in GetPartition in gfd_validation.cpp (immediately return 0)
- Disable tests causing float-to-long cast when result is infinity in tests/test_types.cpp
- Use std::chrono::high_resolution_clock instead of std::chrono::_V2::high_resolution_clock in
  fastod/util/timer.h, because symbol versioning is gcc-specific
- Use &Insert instead of this->Insert in KDTree constructor
- Use system_clock everywhere instead of mix of system_clock and
  high_resolution_clock in Cords::ExecuteInternal
- Add fallback behaviour in hymd::utility::MdLessPairs if operator <=> for vectors isn't availible
- Add explicit #include <string> in exceptions.h
- Add template keyword in CanonicalOD::IsValid to avoid most vexing parse (see cross-platform guide in wiki)
- Explicitly cast kSeed_ to result_type in des/rng.h, because result_type of mt19937 is always 32-bit
  and it's not bound to some built-in integral type
- Use reverse iterators to traverse set in reverse order, instead of
  strange behaviour with direct iterators in egfd_validation.cpp/ReverseConstruction
Add information about other compilers in README.
Extra build instructions (Linux & Clang, macOS & LLVM CLang, macOS & GCC)
are now moved to wiki
- Use simple RAII wrapper of std::thread instead of std::jthread when the latter isn't implemented
- Use custom implementations of std::bitset::_Find_first and _Find_next when gcc intrinsics
  aren't availible. Also, implement some utility functions using custom FindFirst and FindNext
Don't use features, which behaviour is implementation-defined and differ
in libstdc++ and libc++. Instead use "stable" versions:
- sort pairs by value if frequencies are equal in Cords' FrequencyHandler::InitFrequencyHandler
- Use std::stable_sort instead of std::sort in DES::GetRandomPopulationInDomainds
- Use std::set instead of std::unordered_set in differential_functions.cpp/GetRandIndices
- Use std::stable_sort in PDFTane::CalculatePFDError instead of std::sort
Add tests for Clang on Linux, LLVM Clang on macOS and Apple Clang on macOS.
Also, bump boost version used in CI, as 1.8.10 produces an error on macOS with LLVM Clang.
Here it's said that boost 1.85.0 works fine:
bambulab/BambuStudio#3957
Aggregate initialization isn't availible on Apple Clang. Use direct-list-initialization
instead wherewer possible:
- Split::IndexSearchSpace
- MinPickerLattice::AddGeneralizations
- OneByOnePicker::AddGeneralizations
- md_lattice/Specializer
- MdLattice::GetAll
- hymd::LhsNode
-     ::BatchValidator
- SimilarityData::Creator
- BatchValidator::MultiCardPartitionElementProvider
- MD::GetDescription
- order::GetIndexedByteData
- python_bindings::BindOd
- model::DD

Define constructor elsewhere:
- test_algo_interfaces/KeysTestParams
- test_dc_verifier/DCTestParams
- test_ind_verifier/INDVerifierTestConfig
- test_pfdtane/PFDTaneValidationParams
- test_tane_afd_measures/TaneValidationParams
-                       /PdepSelfValidationParams
- test_typed_column_data/TypeParsingParams
Add missing steps in install-dependencies action.
Add configruation to core-tests and bindings-tests workflows.
Add --formula flag to brew install cmake to disable warning.
Create a separate job for macOS wheel matrix generation due to
wheels autoskipping on x86_64 ubuntu runner.
Create matrix merge job to merge all matrices into a single.
Add macOS support to the wheel build job.

Set C++ as CMake project language, remove C-compilers exports.
@Vdaleke Vdaleke force-pushed the feature/windows-pip-package branch 10 times, most recently from 8749a3b to a84ad22 Compare January 26, 2025 19:28
@Vdaleke Vdaleke force-pushed the feature/windows-pip-package branch 10 times, most recently from e63df99 to 1e2c71f Compare January 26, 2025 22:24
@Vdaleke Vdaleke force-pushed the feature/windows-pip-package branch from 1e2c71f to 4d8d32b Compare January 26, 2025 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants