Read memory map from backend to fix infinite string search issue #786
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements comprehensive memory region reading from debug backends to resolve the critical performance issue where string search attempts to read the entire address space (0xffffffff or 0xffffffffffffffff bytes), causing operations to hang indefinitely.
Problem
Currently, the debugger only has limited segment information (binary path and start address) with no knowledge of segment lengths or memory permissions. This causes two major issues:
DebuggerFileAccessor
reports the entire address space as readable (UINT64_MAX
), so string search tries to read all memory addresses, never completing.Solution
Added complete memory region infrastructure with backend-specific implementations:
Core Infrastructure
DebugMemoryRegion
: New struct storing start/end addresses, permissions (read/write/execute), region name, and associated moduleGetMemoryRegions()
: Virtual method added toDebugAdapter
base classDebuggerMemoryRegions
: Management class for caching and validating memory regionsDebuggerMemory::ReadBlock()
now validates addresses against readable regions before attempting readsBackend Implementations
/proc/PID/maps
to extract detailed Linux memory layout with permissionsSBProcess::GetMemoryRegionInfo()
for cross-platform region enumerationIDebugDataSpaces::QueryVirtual()
for Windows memory regionsExample Memory Layout (Linux)
Performance Impact
Before: String search attempts to scan entire address space
After: Only scans valid memory regions
Testing
Comprehensive test suite validates:
/proc/maps
formatThe implementation is robust, handles all edge cases, and provides graceful fallback when memory regions aren't available.
Fixes #96.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.