Remote sense gdb stub, binja UI works with mame coleco

Author: lwerdna

DebugAdapter.py

@@ -21,6 +21,7 @@ class ADAPTER_TYPE(Enum):
 	REMOTE_DBGENG = auto()
 	REMOTE_GDB = auto()
 	REMOTE_LLDB = auto()
+	REMOTE_SENSE = auto()
 
 	@staticmethod
 	def use_exec(adapter_type):
@@ -36,7 +37,8 @@ def use_connect(adapter_type):
 		return adapter_type in [
 			ADAPTER_TYPE.REMOTE_DBGENG,
 			ADAPTER_TYPE.REMOTE_GDB,
-			ADAPTER_TYPE.REMOTE_LLDB
+			ADAPTER_TYPE.REMOTE_LLDB,
+			ADAPTER_TYPE.REMOTE_SENSE
 		]
 
 	@staticmethod
@@ -50,6 +52,7 @@ def can_use(adapter_type):
 				ADAPTER_TYPE.REMOTE_DBGENG,
 				ADAPTER_TYPE.REMOTE_GDB,
 				ADAPTER_TYPE.REMOTE_LLDB,
+				ADAPTER_TYPE.REMOTE_SENSE
 			]
 		elif system == 'Linux':
 			return adapter_type in [
@@ -58,6 +61,7 @@ def can_use(adapter_type):
 				ADAPTER_TYPE.REMOTE_DBGENG,
 				ADAPTER_TYPE.REMOTE_GDB,
 				ADAPTER_TYPE.REMOTE_LLDB,
+				ADAPTER_TYPE.REMOTE_SENSE
 			]
 		elif system == 'Darwin':
 			return adapter_type in [
@@ -66,6 +70,7 @@ def can_use(adapter_type):
 				ADAPTER_TYPE.REMOTE_DBGENG,
 				ADAPTER_TYPE.REMOTE_GDB,
 				ADAPTER_TYPE.REMOTE_LLDB,
+				ADAPTER_TYPE.REMOTE_SENSE
 			]
 		else:
 			return False
@@ -93,6 +98,8 @@ def get_new_adapter(adapter_type = ADAPTER_TYPE.DEFAULT, **kwargs):
 		return gdb.DebugAdapterGdb(**kwargs)
 	elif adapter_type == ADAPTER_TYPE.LOCAL_LLDB or adapter_type == ADAPTER_TYPE.REMOTE_LLDB:
 		return lldb.DebugAdapterLLDB(**kwargs)
+	elif adapter_type == ADAPTER_TYPE.REMOTE_SENSE:
+		return lldbDebugAdapterGdbLike(**kwargs)
 	elif adapter_type == ADAPTER_TYPE.DEFAULT:
 		return get_adapter_for_current_system(**kwargs)
 	else:

binjaplug.py

@@ -8,7 +8,7 @@
 
 from binaryninja import Architecture, BinaryView, Symbol, SymbolType, Type, Structure, StructureType, FunctionGraphType, LowLevelILOperation, MediumLevelILOperation, core_ui_enabled
 
-from . import DebugAdapter, ProcessView, dbgeng, QueuedAdapter
+from . import DebugAdapter, ProcessView, dbgeng, gdblike, QueuedAdapter
 
 if core_ui_enabled():
     try:
@@ -481,9 +481,7 @@ def ip(self):
 			return self.registers['rip']
 		elif self.remote_arch.name == 'x86':
 			return self.registers['eip']
-		elif self.remote_arch.name == 'aarch64':
-			return self.registers['pc']
-		elif self.remote_arch.name in ['arm', 'armv7']:
+		elif self.remote_arch.name in ['aarch64', 'arm', 'armv7', 'Z80']:
 			return self.registers['pc']
 		else:
 			raise NotImplementedError('unimplemented architecture %s' % self.remote_arch.name)
@@ -504,9 +502,7 @@ def stack_pointer(self):
 			return self.registers['rsp']
 		elif self.remote_arch.name == 'x86':
 			return self.registers['esp']
-		elif self.remote_arch.name == 'aarch64':
-			return self.registers['sp']
-		elif self.remote_arch.name in ['arm', 'armv7']:
+		elif self.remote_arch.name in ['aarch64', 'arm', 'armv7', 'Z80']:
 			return self.registers['sp']
 		else:
 			raise NotImplementedError('unimplemented architecture %s' % self.remote_arch.name)
@@ -668,20 +664,35 @@ def attach(self):
 			raise Exception("Tried to attach but already debugging")
 
 		self.connecting = True
-		self.adapter = DebugAdapter.get_new_adapter(self.adapter_type, stdout=self.on_stdout)
-		if DebugAdapter.ADAPTER_TYPE.use_connect(self.adapter_type):
+
+		# can the remote sense create the appropriate adapter?
+		if self.adapter_type == DebugAdapter.ADAPTER_TYPE.REMOTE_SENSE:
 			try:
-				self.adapter = QueuedAdapter.QueuedAdapter(self.adapter)
-				self.adapter.setup()
-				self.adapter.connect(self.remote_host, self.remote_port)
-				self.connecting = False
+				self.adapter = gdblike.connect_sense(self.remote_host, self.remote_port)
+				if self.adapter:
+					self.adapter = QueuedAdapter.QueuedAdapter(self.adapter)
+					self.connecting = False
 			except Exception as e:
 				self.connecting = False
 				self.adapter = None
 				raise e
-		else:
-			self.connecting = False
-			raise Exception("cannot connect to adapter of type %s" % self.adapter_type)
+
+		if self.connecting:
+			self.adapter = DebugAdapter.get_new_adapter(self.adapter_type, stdout=self.on_stdout)
+
+			if DebugAdapter.ADAPTER_TYPE.use_connect(self.adapter_type):
+				try:
+					self.adapter = QueuedAdapter.QueuedAdapter(self.adapter)
+					self.adapter.setup()
+					self.adapter.connect(self.remote_host, self.remote_port)
+					self.connecting = False
+				except Exception as e:
+					self.connecting = False
+					self.adapter = None
+					raise e
+			else:
+				self.connecting = False
+				raise Exception("cannot connect to adapter of type %s" % self.adapter_type)
 
 		self.memory_view.update_base()
 

mame_coleco.py

@@ -59,9 +59,6 @@ def connect_continued(self, sock,connection):
 		self.tid = 0
 		self.target_pid_ = 0
 
-	def mem_modules(self, cache_ok=True):
-		raise NotImplementedError('no module list on ColecoVision')
-
 	def go(self):
 		self.reg_cache = {}
 		(reason, reason_data) = self.go_generic('c')
@@ -74,6 +71,12 @@ def step_into(self):
 		self.handle_stop(reason, reason_data)
 		return (reason, reason_data)
 
+	# reg read
+	def reg_read(self, name):
+		# if IL evaluated (to compute next instruction), the disassembler gives uppercase register names
+		# convert to lowercase names mame expects
+		return gdblike.DebugAdapterGdbLike.reg_read(self, name.lower())
+
 	# thread stuff
 	def thread_list(self):
 		return [0]
@@ -86,7 +89,10 @@ def thread_select(self, tid):
 			raise DebugAdapter.GeneralError('mame_coleco has only one implicit thread: 0')
 
 	#
-	def mem_modules(self):
+	def target_base(self):
+		return 0x8000
+
+	def mem_modules(self, cache_ok=True):
 		#[0000, 2000) - BIOS ROM
 		#[2000, 4000) - Expansion Port
 		#[4000, 6000) - Expansion Port