feat: preferred stream settings #1060
Conversation
|
please show a screenshot |
| <div className="vcd-screen-picker-save-control"> | ||
| <div | ||
| className={`vcd-screen-picker-save-checkbox ${Settings.stream?.preferred && "checked"}`} | ||
| onClick={() => { |
There was a problem hiding this comment.
this markup is very messy and not semantic (using a plain div as a checkbox is very bad. at the very least it should have aria attributes like role that tell user agents that this is a checkbox for visually impaired people and other users of screenreaders). have a look at the rest of Vesktop (& Vencord) Settings UI and see how those implement things like Switches, Checkboxes. Vencord exports a bunch of Discord Components you can use instead of implementing stuff yourself
|
I initially attempted to use the existing Switch component, but it appeared inconsistent with the current UI due to its hardcoded colors. I'm open to using it if it's the preferred solution. In that case, I can refine the markup based on your suggestions. |
|
I see, that's fair yeah! Switch is likely not the right Component, but Discord also has a Checkbox component that should be exactly what you want
Vencord doesn't export it for some reason, but you can manually find it via
|
|
I updated the component using the Checkbox component. Regarding preferred settings for audio, currently, only the "Entire System" option can be saved. However, I believe it's best to exclude audio settings altogether.
|
Save stream settings for reuse (resolution, FPS, content type). Audio source is excluded due to per-stream variability.