Potential Audio Fix for Windows #1068
Open
+10,638
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Key modifications: Added Windows-specific audio handling - Included path-based app name detection - Prepared structure for virtual audio cable routing - Added placeholder for audio routing constraints Note: Precise virtual audio cable implementation requires platform-specific audio routing libraries or APIs. You may need to integrate additional Windows audio routing mechanisms.
Added in the copyright (I accidently removed) added in integration for windows. New Key features: - Advanced audio routing for Windows - Virtual audio device detection - Configurable excluded processes - Fallback mechanisms - Cross-platform support with Wayland handling
nin0-dev
reviewed
Jan 30, 2025
Key changes made: Organized imports into three groups: External dependencies (electron) Node.js built-in modules (child_process, path) Internal project imports (renderer, shared, utils) Replaced all single quotes with double quotes for consistency: String literals Import statements Object properties Console messages Removed unused path import (though kept it in the same position in case it's needed later) Added proper spacing between imports and the rest of the code
|
my apologies, I am still newish to typescript lmao, these changes should have fixed it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for issue 569
As mentioned by @quadrinex, we can setup a virtual cable and exclude the "vesktop.exe" executable from this.