-
-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(linux): Emit D-Bus signal directly for dock notification badges #686
Open
Covkie
wants to merge
16
commits into
Vencord:main
Choose a base branch
from
Covkie:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+166
−4
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
dd703eb
feat(linix): Emit D-Bus signal directly for dock notification badges
Covkie dda7c7c
Unread badge and suggestions
Covkie cdce21e
Merge branch 'main' into main
Covkie 6af88e0
remove if horror
Covkie d850a62
feat: Include message requests in count
Covkie bd08e18
Merge branch 'main' into main
Vendicated b45fd3a
real error message
Covkie 4bd418d
remove redundant function
Covkie 3ff6e45
Merge branch 'main' of https://github.com/Covkie/Vesktop
Covkie 9037317
formatting + V's suggested changes to title prefix pruning
Covkie 075af17
Combine title pruning operation
Covkie 66c2862
Switch to dbus lib & support flatpak .desktop
Covkie 310e661
Merge remote-tracking branch 'upstream/main'
Covkie cab6ba5
propper count signature
Covkie 9716ff4
fix: excessive connection creation
Covkie 633ce3f
Merge remote-tracking branch 'upstream/main'
Covkie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
/* | ||
* SPDX-License-Identifier: GPL-3.0 | ||
* Vesktop, a desktop app aiming to give you a snappier Discord Experience | ||
* Copyright (c) 2023 Vendicated and Vencord contributors | ||
*/ | ||
|
||
import dbus from "@homebridge/dbus-native"; | ||
|
||
let sessionBus: dbus.MessageBus | null; | ||
|
||
export function getSessionBus(): dbus.MessageBus { | ||
if (!sessionBus) sessionBus = dbus.sessionBus(); | ||
return sessionBus; | ||
} | ||
|
||
export { dbus }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding a new library that adds more than 200kb of javascript just for one single dbus call is pretty bad
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#517 also uses it for accent calls.
we were shelling out before but #686 (comment)