Skip to content

fix: only filter by user assets if they have some #5196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
therealemjy merged 1 commit into from
Dec 26, 2025
Merged

fix: only filter by user assets if they have some #5196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fancy-lines-raise.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@venusprotocol/evm": patch
---

always show user assets only filter
13 changes: 5 additions & 8 deletions apps/evm/src/containers/MarketTable/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ export const MarketTable: React.FC<MarketTableProps> = ({
const {
assets: filteredAssets,
pausedAssetsExist,
userHasAssets,
searchValue,
onSearchValueChange,
showPausedAssets,
Expand Down Expand Up @@ -152,13 +151,11 @@ export const MarketTable: React.FC<MarketTableProps> = ({
/>
)}

{userHasAssets && (
<Toggle
onChange={() => setShowUserAssetsOnly(!showUserAssetsOnly)}
value={showUserAssetsOnly}
label={t('marketTable.userAssetsOnlyToggle.label')}
/>
)}
<Toggle
onChange={() => setShowUserAssetsOnly(!showUserAssetsOnly)}
value={showUserAssetsOnly}
label={t('marketTable.userAssetsOnlyToggle.label')}
/>

{userEModeGroup && (
<Toggle
Expand Down
8 changes: 0 additions & 8 deletions apps/evm/src/containers/MarketTable/useControls/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,16 +18,9 @@ export const useControls = ({

const { showPausedAssets, showUserAssetsOnly, showUserEModeAssetsOnly } = userChainSettings;

let userHasAssets = false;
let pausedAssetsExist = false;

assets.forEach(asset => {
const isUserAsset = asset.userWalletBalanceTokens.isGreaterThan(0);

if (isUserAsset && !userHasAssets) {
userHasAssets = true;
}

const isPaused = isAssetPaused({ disabledTokenActions: asset.disabledTokenActions });
if (isPaused && !pausedAssetsExist) {
pausedAssetsExist = true;
Expand Down Expand Up @@ -86,7 +79,6 @@ export const useControls = ({
setShowUserEModeAssetsOnly,
onSearchValueChange: setSearchValue,
pausedAssetsExist,
userHasAssets,
showPausedAssets,
showUserAssetsOnly,
showUserEModeAssetsOnly,
Expand Down