[VPD-314]: Add enterMarketBehalf support to Comptroller #640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exef
previously approved these changes
Nov 19, 2025
Exef
previously approved these changes
Nov 20, 2025
| { | ||
| "cutParams": [ | ||
| [ | ||
| "0x87FdF72FA2fB29Cb43f03aCa261A8DC2C613a860", |
Contributor
There was a problem hiding this comment.
web3rover
previously approved these changes
Nov 20, 2025
fred-venus
reviewed
Nov 27, 2025
| "0x3093c11e", | ||
| "0xd137f36e", | ||
| "0xd463654c", | ||
| "0x4d99c776" |
Contributor
There was a problem hiding this comment.
aditya, curious, is there a tool to generate the selector list of a facet
Contributor
There was a problem hiding this comment.
ah, nvm, guess u r calling unitroller.facetFunctionSelectors
fred-venus
reviewed
Nov 27, 2025
| const NEW_MARKET_FACET = "0x87FdF72FA2fB29Cb43f03aCa261A8DC2C613a860"; | ||
|
|
||
| // Function selector for enterMarketBehalf(address,address) | ||
| const ENTER_MARKET_BEHALF_SELECTOR = "0xd585c3c6"; |
Contributor
There was a problem hiding this comment.
cast sig "enterMarketBehalf(address,address)"
0xd585c3c6
fred-venus
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves VEN